-
Notifications
You must be signed in to change notification settings - Fork 435
Fix AddOrUpdateAnnotation recipe changing implicit value
into explicit value
in annotations with arrays
#5693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jevanlingen
merged 10 commits into
main
from
AddOrUpdateAnnotationAttribute-change-implicit-into-explicit-value-for-arrays
Jul 2, 2025
Merged
Fix AddOrUpdateAnnotation recipe changing implicit value
into explicit value
in annotations with arrays
#5693
jevanlingen
merged 10 commits into
main
from
AddOrUpdateAnnotationAttribute-change-implicit-into-explicit-value-for-arrays
Jul 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cit `value` in annotations with arrays
27b9c64
to
07a56ef
Compare
…it-into-explicit-value-for-arrays
JohannisK
reviewed
Jul 1, 2025
rewrite-java-test/src/test/java/org/openrewrite/java/AddOrUpdateAnnotationAttributeTest.java
Show resolved
Hide resolved
JohannisK
reviewed
Jul 1, 2025
rewrite-java-test/src/test/java/org/openrewrite/java/AddOrUpdateAnnotationAttributeTest.java
Show resolved
Hide resolved
…it-into-explicit-value-for-arrays
JohannisK
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
When updating an existing annotation property, the recipe should not change implicit values.
What's your motivation?
The recipe creates uncompilable code when using an array with a implicit value.
For example:
is turned into:
where you would have expected:
Checklist