Add merge parameter to ChangePluginConfiguration recipe #5650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrakshith21
force-pushed
the
enhance-change-plugin-configuration-recipe
branch
from
36b5e76 to
7227ed2
Compare
|
@timtebeek any comments? |
mrakshith21
force-pushed
the
enhance-change-plugin-configuration-recipe
branch
from
7227ed2 to
2be74a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added merge parameter to ChangePluginConfiguration recipe
What's your motivation?
Also, I have a couple of plugin related upgrades for java 21 upgrade for which this feature would help. I would like to contribute those after this.
Anything in particular you'd like reviewers to focus on?
The implementation goes through tags directly mentioned in the argument, and calls addOrupdateChild on them - new values will be merged and matching ones will be overridden. I have not done a recursive check, but let me know if that was the intended solution mentioned by @timtebeek in the issue linked. Atleast the ones I have in mind for the java 21 upgrade do not require a recursive check. Thanks!
Anyone you would like to review specifically?
@timtebeek
Checklist