Handle non-@Rule TemporaryFolder fields

[amishra-u]

What's changed?

The TemporaryFolderToTempDir recipe did not correctly handle TemporaryFolder instances that were not annotated with @rule.
Issue: When the recipe made other changes, the ChangeType incorrectly migrates new TemporaryFolder() to new File().

This PR updates the recipe to properly handle TemporaryFolder instances that are not explicitly annotated with @rule,

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[timtebeek]

That's some interesting usage patterns you're uncovering there @amishra-u ; thanks for reporting them all here in the form of pull requests. I've asked colleagues to help out with reviews as it's at times a bit much to keep up, but know it's appreciated! 😅

[amishra-u]

That's some interesting usage patterns you're uncovering there @amishra-u ; thanks for reporting them all here in the form of pull requests. I've asked colleagues to help out with reviews as it's at times a bit much to keep up, but know it's appreciated! 😅

Thanks! I’m running these recipes on a repository with around 50k test classes, so they’re definitely getting battle-tested. By the time we're done, these should be rock-solid. Appreciate you looping others in for reviews—it really helps!

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 1011-1013
  • lines 2443-2503
  • lines 2576-2575

[timtebeek]

Good to have this odd bit of usage cleared out as well; thanks!

[github-actions]

Some suggestions could not be made:

• src/main/resources/META-INF/rewrite/examples.yml
  • lines 2443-2503
  • lines 2576-2575

[amishra-u]

👍