Skip to content

Include additional AssertJ rules/recipes from Error Prone Support #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Include additional AssertJ rules/recipes from Error Prone Support #713

wants to merge 8 commits into from

Conversation

timtebeek
Copy link
Member

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 26, 2025
@timtebeek timtebeek self-assigned this Apr 26, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Apr 26, 2025
@timtebeek timtebeek added recipe Recipe request assertj bug Something isn't working labels Apr 26, 2025
@timtebeek timtebeek mentioned this pull request Apr 26, 2025
Open
github-actions[bot]

This comment was marked as outdated.

Sign in to view

github-actions[bot]

This comment was marked as outdated.

Sign in to view

github-actions[bot]
github-actions bot reviewed Apr 30, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 2443-2503
    • lines 2576-2575
    • lines 3383-3401
    • lines 3437-3436
  • src/test/java/org/openrewrite/java/testing/junit5/JUnit5BestPracticesTest.java
    • lines 25-26

@timtebeek timtebeek marked this pull request as draft May 1, 2025 18:25
github-actions[bot]
github-actions bot reviewed May 3, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 2443-2503
    • lines 2576-2575
    • lines 3383-3401
    • lines 3437-3436
  • src/test/java/org/openrewrite/java/testing/junit5/JUnit5BestPracticesTest.java
    • lines 25-26

github-actions[bot]
github-actions bot reviewed May 3, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 2443-2503
    • lines 2576-2575
    • lines 3383-3401
    • lines 3437-3436
  • src/test/java/org/openrewrite/java/testing/junit5/JUnit5BestPracticesTest.java
    • lines 25-26

@timtebeek timtebeek mentioned this pull request May 3, 2025
Merged
@timtebeek
Copy link
Member Author

This PR should help some of the Map cases that now fail to match again:

@timtebeek timtebeek mentioned this pull request May 3, 2025
Merged
@timtebeek timtebeek moved this from Ready to Review to In Progress in OpenRewrite May 4, 2025
github-actions[bot]
github-actions bot reviewed May 4, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 1011-1013
    • lines 2443-2503
    • lines 2576-2575

github-actions[bot]
github-actions bot reviewed May 17, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/resources/META-INF/rewrite/examples.yml
    • lines 2443-2503
    • lines 2576-2575

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@timtebeek timtebeek

Labels
assertj bug Something isn't working recipe Recipe request
Projects
OpenRewrite
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimplifyChainedAssertJAssertion should skip Optional values with wildcards
1 participant
@timtebeek