-
Notifications
You must be signed in to change notification settings - Fork 90
Jakarta EE11 / Faces 4.1 #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- build.gradle.kts
- lines 40-39
- src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
- lines 25-25
Much appreciated! Having just an early skeleton already helps others to tag on additions still to come. Let me know when you think we can merge a first iteration. From my side I'd love to see at least a minimal unit test: @Test
void loadRecipesToDetectPotentialIssues() {
rewriteRun(
spec -> spec.recipeFromResources("org.openrewrite.java.migrate.jakarta.JakartaEE11")
);
} That then triggers loading these recipes and through that a number of validations built into the testing support we have. |
Yep i will work on a minimal test. |
Basic test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- build.gradle.kts
- lines 40-39
- src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
- lines 25-25
src/test/java/org/openrewrite/java/migrate/jakarta/JakartaEE11Test.java
Outdated
Show resolved
Hide resolved
…Test.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- build.gradle.kts
- lines 40-39
- src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
- lines 25-25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot yet again @melloware !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- build.gradle.kts
- lines 40-39
- src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
- lines 25-25
Thought i would get this started...