Skip to content

Jakarta EE11 / Faces 4.1 #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025
Merged

Jakarta EE11 / Faces 4.1 #703

merged 5 commits into from
Apr 12, 2025

Conversation

melloware
Copy link
Contributor

Thought i would get this started...

@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Apr 10, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • build.gradle.kts
    • lines 40-39
  • src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
    • lines 25-25

@timtebeek
Copy link
Contributor

Much appreciated! Having just an early skeleton already helps others to tag on additions still to come. Let me know when you think we can merge a first iteration.

From my side I'd love to see at least a minimal unit test:

@Test
void loadRecipesToDetectPotentialIssues() {
  rewriteRun(
    spec -> spec.recipeFromResources("org.openrewrite.java.migrate.jakarta.JakartaEE11")
  );
}

That then triggers loading these recipes and through that a number of validations built into the testing support we have.

@timtebeek timtebeek added the recipe Recipe requested label Apr 11, 2025
@melloware
Copy link
Contributor Author

Yep i will work on a minimal test.

@melloware
Copy link
Contributor Author

Basic test added

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • build.gradle.kts
    • lines 40-39
  • src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
    • lines 25-25

@timtebeek timtebeek self-requested a review April 11, 2025 17:20
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Apr 11, 2025
…Test.java

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • build.gradle.kts
    • lines 40-39
  • src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
    • lines 25-25

Copy link
Contributor

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot yet again @melloware !

@timtebeek timtebeek merged commit e9b5b02 into openrewrite:main Apr 12, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Apr 12, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • build.gradle.kts
    • lines 40-39
  • src/test/java/org/openrewrite/java/migrate/jakarta/UpdateXJCBindingsToJakartaEE.java
    • lines 25-25

@melloware melloware deleted the ee11 branch April 12, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe requested
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants