-
Notifications
You must be signed in to change notification settings - Fork 90
Fix #695: Apache Commons Email2 #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
newVersion: 2.0.x | ||
- org.openrewrite.java.ChangePackage: | ||
oldPackageName: org.apache.commons.mail | ||
newPackageName: org.apache.commons.mail2.jakarta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But org.apache.commons.mail.EmailException is moved to org.apache.commons.mail2.core.EmailException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see they broke 3 classes off into common: https://github.com/apache/commons-email/tree/master/commons-email2-core/src/main/java/org/apache/commons/mail2/core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK updated to move those 3 specific classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks both! Great to have you involved with the project to make this easier for everyone. Also very helpful that you're cross reviewing PRs already.
Fix #695: Apache Commons Email2