Allow custom ExternArgument in extern declaration #83
Conversation
This is useful if people want to specify ArrayReferenceType as an argument to an extern function. ArrayReferenceType require an explicit Access modifier (mutable or readonly). Since this is just one edge case, we can let users still specify just the type for all other extern declarations.
oqpy/subroutines.py
Outdated
|
|
||
| SubroutineParams = [oqpy.Program, VarArg(AstConvertible)] | ||
|
|
||
| FnType = TypeVar("FnType", bound=Callable[..., Any]) | ||
|
|
||
|
|
||
| @dataclass | ||
| class OqpyArgument: |
There was a problem hiding this comment.
Can we keep the style that we use for other classes? -> OQPyArgument.
oqpy/subroutines.py
Outdated
|
|
||
| name: str | ||
| dtype: ast.ClassicalType | ||
| access: Literal["readonly", "mutable"] |
There was a problem hiding this comment.
Can we add None and make it the default value?
|
|
||
| name: str | ||
| dtype: ast.ClassicalType | ||
| access: Literal["readonly", "mutable"] | None = None |
There was a problem hiding this comment.
This follows the precedent established by the OpenQASM reference AST, so it's fine to have here. But I will say that I think the underlying premise is slightly mistaken. Access modifiers or type qualifiers make most sense as part of the type itself. In a subroutine, if you ask "what is the type of this variable" it's nice to be able to say "a mutable array reference".
There was a problem hiding this comment.
I might agree. After reading the reference AST code and the parser grammar, I think we should cut a ticket to gh/openqasm and fix it there first. ArrayReferenceType is only used with *Argument node but the modifier has been added to the *Argument node and not the type node.
This is useful if we want to specify ArrayReferenceType as an argument to an extern function. ArrayReferenceType require an explicit Access modifier (mutable or readonly). Since this is just one edge case, we can let users still specify just the type for all other extern declarations.
I have added a test that demos its usage.