Specify cache key via protocol #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragm
reviewed
Oct 28, 2023
Comment on lines
+477
to
+478
| if item._oqpy_cache_key is None: | ||
| item._oqpy_cache_key = uuid.uuid1() |
There was a problem hiding this comment.
Assuming that uuid are unique, this essentially means that we are turning cache off for those elements where _oqpy_cache_key is not provided. If that is the case, we can just do away with using uuid and return item._to_oqpy_expression().to_ast(program) on every invocation where _oqpy_cache_key is absent.
This will also avoid (however unlikely) uuid hash collisions.
There was a problem hiding this comment.
Hmm I don't think that's true. If the same object is used multiple times, (which was the original motivation with the cache, since we used id as a key), then the _to_oqpy_expression should only get called once.
Not worried about uuid collisions :) https://jhall.io/archive/2021/05/19/what-are-the-odds/
braised-babbage
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
idto cache objects forCachedExpressionConvertibleis a bug, because the id may be reused between objects resulting in incorrect retrieval if the objects have a lifetime shorter than that of the program.