Skip to content

Fix subroutines with array arguments #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

jcjaskula-aws
Copy link
Collaborator

class_getitem creates a partial and not a class, which breaks the type hints mechanism.

Solution: we retrieve the class from the func field.

Copy link
Collaborator

@PhilReinhold PhilReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion for comment, otherwise looks good.

Co-authored-by: Phil Reinhold <[email protected]>
@jcjaskula-aws jcjaskula-aws merged commit d102a5b into main Oct 5, 2023
@jcjaskula-aws jcjaskula-aws deleted the jcjaskula-aws/fix_subroutine_with_array_arg branch October 5, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants