Skip to content

Improve test coverage #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 29, 2023
Merged

Improve test coverage #74

merged 7 commits into from
Sep 29, 2023

Conversation

jcjaskula-aws
Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws commented Sep 26, 2023 •
edited
Loading

  • Set test coverage threshold to 100%
  • increase test coverage to 100%
  • upgrade cryptography to 41.0.4

@jcjaskula-aws jcjaskula-aws marked this pull request as ready for review September 26, 2023 22:30
PhilReinhold
PhilReinhold approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@PhilReinhold PhilReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great! I'm actually surprised it didn't take more additions to get to full coverage.

@PhilReinhold PhilReinhold merged commit 895d072 into main Sep 29, 2023
@jcjaskula-aws jcjaskula-aws deleted the jcjaskula-aws/improve_test_coverage branch September 29, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilReinhold PhilReinhold PhilReinhold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcjaskula-aws @PhilReinhold