Skip to content

Convert python slice into AST node #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

jcjaskula-aws
Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws commented Sep 26, 2023

slices are not usable with classical vars because of the _validate_get_item function.

closes #71

@jcjaskula-aws jcjaskula-aws force-pushed the jcjaskula-aws/add_slice_ast_converter branch from c3cd286 to 692e0e5 Compare September 26, 2023 16:38
@jcjaskula-aws jcjaskula-aws marked this pull request as ready for review September 26, 2023 22:36
Copy link
Collaborator

@PhilReinhold PhilReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some test request, but otherwise merge at your leisure.

@jcjaskula-aws jcjaskula-aws merged commit 70bc029 into main Sep 27, 2023
@jcjaskula-aws jcjaskula-aws deleted the jcjaskula-aws/add_slice_ast_converter branch September 27, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make slice AstConvertible to range for use in array slicing
2 participants