Qubit and BitVar supports get item #67
Conversation
|
@PhilReinhold This PR closes issue #8 and #62. Could you review and provide feedback on the implementation? Appreciated! |
yitchen-tim
changed the title
oqpy/quantum_types.py
Outdated
| def __getitem__(self, index: AstConvertible) -> OQIndexExpression: | ||
| if self.size is None: | ||
| raise TypeError(f"'{self.name}' is not subscriptable") | ||
| return OQIndexExpression(collection=self, index=index, type=ast.Identifier) |
There was a problem hiding this comment.
I think returning an OQIndexExpression here is not quite correct, since OQIndexExpression is a subtype of OQPyExpression which is only for classical typed expressions. I think here you could either make a new type (e.g. IndexedQubitArray) or just return the ast.IndexedExpresssion directly.
There was a problem hiding this comment.
thanks for the feedback, I updated and added a IndexedQubitArray class
| # Todo (#51): support QubitArray | ||
| class QubitArray: | ||
| """Represents an array of qubits.""" | ||
| class IndexedQubitArray: |
There was a problem hiding this comment.
Reason for not being a subclass of OQPyExpression: There is no ast type for qubits
Reason for not being a subclass of Var: It cannot not be declared
| decl = ast.QubitDeclaration(ast.Identifier(self.name), size=None) | ||
| decl = ast.QubitDeclaration( | ||
| ast.Identifier(self.name), | ||
| size=ast.IntegerLiteral(self.size) if self.size else self.size, |
There was a problem hiding this comment.
size=ast.IntegerLiteral(self.size) if self.size else None,
is better
Closes #8 and #62
Description of change:
OQIndexExpressiontooqpy.base__getitem__returns anOQIndexExpressionQubitArrayclass