Skip to content

Add .include method #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

braised-babbage
Copy link
Contributor

This adds a Program.include method. Note that like pragma, it is illegal to have include statements outside of the program toplevel.

@braised-babbage
Copy link
Contributor Author

Note that I have tested this locally on Python 3.11. I'm not sure about the CI failures.

@PhilReinhold
Copy link
Collaborator

Note that I have tested this locally on Python 3.11. I'm not sure about the CI failures.

The CI is failing because poetry most recent version dropped support for 3.7, and we weren't pinning poetry. We have a fix in #65 but I can't seem to merge it since I need to override the absence of required checks for 3.7, and I don't have permissions. I also can't seem to tell who does have permissions to do this, since permissions info is apparently only visible to the codeowner by default. Any idea who this might be?

Copy link
Collaborator

@PhilReinhold PhilReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@PhilReinhold PhilReinhold merged commit 0790911 into openqasm:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants