Simplified implementation of gate modifiers #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjaskula-aws
changed the base branch from
jcjaskula-aws/add_gate_modifiers
to
main
PhilReinhold
requested changes
Sep 12, 2023
| qreg[6], | ||
| "rz1", | ||
| control=[qreg[2], qreg[4], qreg[5]], | ||
| neg_control=[qreg[0], qreg[1], qreg[0]], |
There was a problem hiding this comment.
Any particular reason to allow repetition here?
There was a problem hiding this comment.
It is a byproduct of using sets. I just want to test here that controlling twice on the same qubit outputs an OQ code with a single ctrl modifier. I prefer this behavior, which allows users to pass overlapping qubit lists like
prog.gate(0, control=[*[i for i in qubits if i %2], *[i for i in qubits if i % 3]]) and still get a nice-looking output.
PhilReinhold
approved these changes
Sep 25, 2023
jcjaskula-aws
deleted the
jcjaskula-aws/add_gate_modifiers_second_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OQPyGateModifier (#61) is problably unnecessary complex. This PR keeps only the argument method.
Adds 4 keyword arguments to
gate: