Check that generated ast respects type hints #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try to always produce "valid" AST in accordance with the type hints defined on the AST dataclasses. We can check this mechanically in the tests.
There are two failures arising from the AST type hints themselves. A trivial failure comes from a failure inopenpulse.ast
to importtyping.Union
which causes type hint evaluation to fail. A less trivial failure is the fact thatopenqasm.ArrayDefinition
doesn't allowDurationType
forbase_type
. We should clarify if this is intended or not.Edit: both failures are resolved in updated versions of the openpulse/openqasm dependencies.