Skip to content

Detect and convert constants #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2023
Merged

Detect and convert constants #44

merged 1 commit into from
May 30, 2023

Conversation

PhilReinhold
Copy link
Collaborator

Address #40

jcjaskula-aws
jcjaskula-aws approved these changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is inline with what we have but I'd be happy if we have a straightforward answer to my question about AngleVar.

@PhilReinhold PhilReinhold merged commit 6bd9937 into main May 30, 2023
@jcjaskula-aws jcjaskula-aws mentioned this pull request May 30, 2023
Closed
@PhilReinhold PhilReinhold mentioned this pull request Jun 20, 2023
Merged
@jcjaskula-aws jcjaskula-aws deleted the pcrein/detect-and-convert-constants branch June 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcjaskula-aws jcjaskula-aws jcjaskula-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilReinhold @jcjaskula-aws