Skip to content

Convert durations to float and vice versa where appropriate #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 22, 2023

Conversation

PhilReinhold
Copy link
Collaborator

@PhilReinhold PhilReinhold commented May 25, 2023

This is intended on addressing #41

Close #41
Close #6

Copy link
Contributor

@anuragm anuragm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments

Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A lot of good improvements. Would like to open a discussion on make_float.

@PhilReinhold PhilReinhold force-pushed the pcrein/duration-conversion branch from 01804e6 to 431735d Compare June 20, 2023 21:35
Copy link
Collaborator

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@PhilReinhold PhilReinhold merged commit b021dda into main Jun 22, 2023
@jcjaskula-aws jcjaskula-aws deleted the pcrein/duration-conversion branch June 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help user by converting floats to durations and vice versa where appropriate Pick units in duration literals more intelligently.
3 participants