Skip to content

Add pragma #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2023
Merged

Add pragma #35

merged 7 commits into from
May 15, 2023

Conversation

jcjaskula-aws
Copy link
Collaborator

Adds pragmas. This MR follows what the parser would construct even though it conflicts with what one would expect from the AST node definitions (See openqasm/openqasm#468 for more details).

Pragma must be in global scope, which is tested at insertion.

Copy link
Collaborator

@PhilReinhold PhilReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few suggestions. Maybe we can cut a new minor release with the new annotation features 0.2.0?

Copy link
Collaborator

@PhilReinhold PhilReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me!

@PhilReinhold PhilReinhold merged commit 5da2464 into main May 15, 2023
@jcjaskula-aws jcjaskula-aws deleted the jcjaskula-aws/add_pragmas branch May 15, 2023 17:25
yitchen-tim added a commit to ajberdy/oqpy that referenced this pull request May 16, 2023
* Add capability to annotate statements (openqasm#34)

* Add capability to annotate statements

* Address review comments

* style/lint fixes

* Add pragma (openqasm#35)

* Add pragma

* Return better error message

* Extend and reuse add_statement

* Add test for annotation and ifs

* Finalize if before adding annotations

* Fix finalize if with annotation and no else

* Fix typo

* Bump version to 0.2.0 (openqasm#36)

---------

Co-authored-by: Phil Reinhold <[email protected]>
Co-authored-by: Jean-Christophe Jaskula <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants