-
Notifications
You must be signed in to change notification settings - Fork 11
Allow for loops with arbitrary variable type #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jcjaskula-aws
merged 5 commits into
openqasm:main
from
anuragm:anuragm/arbritary-loop-var-type
Feb 27, 2023
Merged
Allow for loops with arbitrary variable type #26
jcjaskula-aws
merged 5 commits into
openqasm:main
from
anuragm:anuragm/arbritary-loop-var-type
Feb 27, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks good to me. I'll leave it to @jcjaskula-aws to merge after final approval |
jcjaskula-aws
approved these changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After giving more thoughts about it, it looks good to me. Approving. Thanks for helping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables for loops over arbitrary kinds of arrays. For example, one might desire to loop over some
float
value. This can be done using the following snippet:which outputs the following QASM program: