Add support for returning values from defcal statements #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to defcal and subroutine statements, added support for using Program.returns in subroutine decorator based on type hinting and added tests.
|
|
|
@PhilReinhold and @jcjaskula-aws would either of you be willing / able to review this PR? |
PhilReinhold
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Small comment, but otherwise this all looks good to me! I'll give @jcjaskula-aws some time to leave any other comments, but if not I think we can merge.
Co-authored-by: Phil Reinhold <[email protected]>
…PortVar, FrameVar and WaveformVar
…ormType and FrameType
jcjaskula-aws
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
returnsmethod to theoqpy.Programclass, for adding return statements todefcaldeclarations.The
Program.returnsstatement can also be used within@subroutinedecorated functions instead of thereturnkeyword, this opens up the possibility of having branching withing such functions that can have multiple return statements.All added code covered by tests
Closes #21