Support latest numpy #14
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I work on
mitiq
and this project is a transitive dependency of ours viaamazon-braket-sdk
. Unfortunately at the moment the two (mitiq
/oqpy
) are incompatible in that they require different versions of numpy. This PR bumps numpy support to the latest release.To do this upgrade, I
poetry install
,pyproject.toml
file,poetry lock
andpoetry install
to get the lock file synced, andmake check-all
to ensure tests/devtools pass.In upgrading numpy to 1.23, support for python 3.7 is dropped and hence that change is reflected here as well. Python 3.7 end of life is in 8 months (https://endoflife.date/python). I understand this may not be desirable.
Let me know if this seems about right, and if upgrading numpy is of interest.