Skip to content

Support latest numpy #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Support latest numpy #14

wants to merge 2 commits into from

Conversation

natestemen
Copy link

Hi there,

I work on mitiq and this project is a transitive dependency of ours via amazon-braket-sdk. Unfortunately at the moment the two (mitiq/oqpy) are incompatible in that they require different versions of numpy. This PR bumps numpy support to the latest release.

To do this upgrade, I

  1. cloned the project and ran poetry install,
  2. modified the pyproject.toml file,
  3. ran poetry lock and poetry install to get the lock file synced, and
  4. ran make check-all to ensure tests/devtools pass.

In upgrading numpy to 1.23, support for python 3.7 is dropped and hence that change is reflected here as well. Python 3.7 end of life is in 8 months (https://endoflife.date/python). I understand this may not be desirable.

Let me know if this seems about right, and if upgrading numpy is of interest.

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2022

CLA assistant check
All committers have signed the CLA.

@karalekas
Copy link
Collaborator

@natestemen thanks for reporting this!

#17 should fix this issue without having to drop support for 3.7, so you should be able to close this PR

@karalekas
Copy link
Collaborator

v0.1.1 is now on pypi

@natestemen
Copy link
Author

Thanks Peter!

@natestemen natestemen closed this Oct 25, 2022
@natestemen natestemen deleted the nts-numpy branch October 25, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants