Skip to content

chore: upgrade pnpm to 9 #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 25, 2024
Merged

chore: upgrade pnpm to 9 #595

merged 4 commits into from
Oct 25, 2024

Conversation

sommeeeer
Copy link
Contributor

this PR bumps pnpm to 9.

btw, pnpm is giving a warning. should we remove workspaces from package.json? or is it used by something else?

 WARN  The "workspaces" field in package.json is not supported by pnpm. Create a "pnpm-workspace.yaml" file instead.

Copy link

changeset-bot bot commented Oct 25, 2024

⚠️ No Changeset found

Latest commit: 79a9554

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@khuezy
Copy link
Contributor

khuezy commented Oct 25, 2024

Yea I think we can remove the workspaces in package.json. We're using the pnpm-workspace.yaml

Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Thanks
I'll merge this one after the release though, just in case

@conico974 conico974 merged commit 2c2b343 into opennextjs:main Oct 25, 2024
1 check passed
@sommeeeer sommeeeer deleted the update-pnpm branch October 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants