Skip to content

Fix: StatefulSet get failed in validateWorkloadSpreadSpec #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

Slideee
Copy link
Contributor

@Slideee Slideee commented Mar 21, 2025

Ⅰ. Describe what this PR does

Fix StatefulSet get failed in validateWorkloadSpreadSpec

Ⅱ. Does this pull request fix one issue?

#1964 #1713

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and furykerry March 21, 2025 08:43
@kruise-bot kruise-bot added the size/XS size/XS: 0-9 label Mar 21, 2025
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 42.72%. Comparing base (7c53444) to head (98b2134).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...loadspread/validating/workloadspread_validation.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
- Coverage   42.75%   42.72%   -0.04%     
==========================================
  Files         314      314              
  Lines       31367    31367              
==========================================
- Hits        13412    13402      -10     
- Misses      16585    16596      +11     
+ Partials     1370     1369       -1     
Flag Coverage Δ
unittests 42.72% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Slideee Slideee force-pushed the 20250321/ws/bugfix branch from 3b14d1b to 98b2134 Compare March 21, 2025 16:35
@Slideee Slideee changed the title Fix: StatefulSet get failed in validateWorkloadSpreadSpec (#1964) Fix: StatefulSet get failed in validateWorkloadSpreadSpec Mar 25, 2025
Copy link
Member

@furykerry furykerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furykerry furykerry merged commit 483dc2f into openkruise:master Mar 28, 2025
50 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants