Skip to content

kruise 1.7.0 #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
Merged

kruise 1.7.0 #112

merged 1 commit into from
Aug 28, 2024

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Aug 8, 2024

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to master. They are not published on branches.

@kruise-bot kruise-bot requested review from FillZpp and furykerry August 8, 2024 08:22
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- list
- patch
- update
- watch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if external cert is enabled, write permission for webhookconguration is no longer needed, plz refer to https://github.com/openkruise/charts/pull/108/files#diff-a0ad238085851715bf9748df6cba990b6cfc476daadf25c2c3960ded5375842c

@zmberg zmberg force-pushed the kruise-1.7.0 branch 2 times, most recently from 1c38eba to 90b82fb Compare August 26, 2024 12:43
@furykerry furykerry removed the request for review from FillZpp August 27, 2024 01:49
@zmberg
Copy link
Member Author

zmberg commented Aug 27, 2024

/lgtm

1 similar comment
@zmberg
Copy link
Member Author

zmberg commented Aug 27, 2024

/lgtm

Signed-off-by: liheng.zms <[email protected]>
@zmberg
Copy link
Member Author

zmberg commented Aug 28, 2024

/lgtm
/approve

@zmberg zmberg merged commit b96d341 into openkruise:master Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants