Skip to content

[PRE REVIEW]: MaDaTS: Managing Data on Tiered Storage for Scientific Workflows #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whedon opened this issue Jul 4, 2018 · 27 comments
Closed

Comments

@whedon
Copy link

whedon commented Jul 4, 2018

Submitting author: @dghoshal-lbl (Devarshi Ghoshal)
Repository: https://github.com/dghoshal-lbl/madats
Version: v1.1.2
Editor: @danielskatz
Reviewers: @ian-taylor, @gflofst

Author instructions

Thanks for submitting your paper to JOSS dghoshal-lbl. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

dghoshal-lbl if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 4, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Jul 4, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 4, 2018

PDF failed to compile for issue #807 with the following error:

/app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon.rb:83:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon.rb:69:in initialize'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/bin/whedon:37:in prepare' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-e0f72c5e8125/bin/whedon:99:in <top (required)>'
from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in load' from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in

'

@arfon
Copy link
Member

arfon commented Jul 4, 2018

@dghoshal-lbl - please take a look at the example paper again and fix up the YAML header.

@dghoshal-lbl
Copy link

Hi @arfon - I have fixed the header and pushed in the changes.

@arfon
Copy link
Member

arfon commented Jul 4, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 4, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 4, 2018

@arfon
Copy link
Member

arfon commented Jul 9, 2018

@danielskatz - is this something you might be interested in editing?

@danielskatz
Copy link

If the authors are ok with me editing, I'm happy to. (There's a small possibility of an informal conflict, though not a formal one according to the JOSS guidelines.)

@dghoshal-lbl - what do you think?

@dghoshal-lbl
Copy link

@danielskatz I am fine with you being the editor. However, I am not sure if there is a possibility of a conflict.

@danielskatz
Copy link

It's not a formal conflict, so let's not worry about it as long as you are ok with me doing this, which you are.

@dghoshal-lbl - can you suggest potential reviewers? In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

@danielskatz
Copy link

@whedon assign @danielskatz as editor

@whedon
Copy link
Author

whedon commented Jul 9, 2018

OK, the editor is @danielskatz

@dghoshal-lbl
Copy link

@danielskatz I am not sure if I have a good idea of who can be the potential reviewers. Since the code is in Python, I think anyone who has a working knowledge of Python can review this. Last time, I submitted a Python software to JOSS, I think @krother was the reviewer.

@danielskatz
Copy link

The potential reviewers don't have to be from the list of reviewers - you can give me suggestions of others as well. For example, if you were submitting a paper on this to a conference, who would you want to review it?

@dghoshal-lbl
Copy link

@danielskatz If there are no potential reviewers assigned to this, one suggestion is: Jay Lofstead (http://www.lofstead.org/)

@danielskatz
Copy link

Thanks @dghoshal-lbl - I'll check with Jay. I've also been trying to find a number of other people through email, but without success so far.

@danielskatz
Copy link

@whedon assign @ian-taylor as reviewer

@whedon whedon assigned danielskatz and unassigned danielskatz Jul 23, 2018
@whedon
Copy link
Author

whedon commented Jul 23, 2018

OK, the reviewer is @ian-taylor

@danielskatz
Copy link

I'm still looking for one more reviewer before I start the review. In addition, @ian-taylor is not available until the 2nd week of August, so this isn't delaying the review.

@danielskatz
Copy link

@whedon add @gflofst as reviewer

@whedon
Copy link
Author

whedon commented Jul 23, 2018

OK, @gflofst is now a reviewer

@danielskatz
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 23, 2018

OK, I've started the review over in #830. Feel free to close this issue now!

@danielskatz
Copy link

yeah, no bananas any more!!! 🎆

@arfon
Copy link
Member

arfon commented Jul 23, 2018

yeah, no bananas any more!!! 🎆

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants