-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: LightLogR: Reproducible analysis of personal light exposure data #7601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
|
👋🏼 @JZauner @cansavvy, @welch16 this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@rwegener2) if you have any questions/concerns. |
Review checklist for @welch16Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @cansavvyConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@JZauner This is a very cool software! I really appreciate the thoroughness here. Enjoyed taking a look at the code base and paper! I don't work with light loggers so the application is not something I have experience with but can certainly understand the need and appreciate software that attempts to standardize data! So only have the minorest of comments and questions here:
|
@JZauner, I agree with @cansavvy that this software is great. In addition to @cansavvy comments, I would like to add:
Overall, I think it is a great package that would be very useful for the community. Good work! |
Thank you very much, @cansavvy and @welch16, for your kind words and constructive suggestions, and to @rwegener2 for coordinating everything! We strive to create a well-developed and user-accessible package, which is why we emphasized tutorials. We believe the suggested changes have made the package more robust and user-friendly. We have implemented the following changes, which are live now as LightLogR 0.4.3. They address all suggestions the reviewers made.
|
Everything looks great, I checked the last point of my review list. |
Sounds good @cansavvy, thanks for the speedy reply! Would you be able to check the final box on your checklist to confirm that you approve of the submission? |
Ah yes of course. Done! |
Lovely. Thanks so much again to @welch16 and @cansavvy for your feedback as reviewers! JOSS wouldn't be possible without you. @JZauner The next step in the review process is that I will go through the paper for a series of checks. I'll be looking for some information from you midway through. After that I will pass it off the the track editor and chief, who will do the final review and publication. |
Post-Review Checklist for Editor and Authors1 - Editor Tasks Prior to AcceptanceEditor checks paper proof:
2 - Additional Author Tasks After Review is Complete
3 - Editor Archiving and Submission RecommendationEditor checks archive generated by author:
Editor double checks paper and recommends submission:
|
@editorialbot generate pdf |
@editorialbot check references |
Great! Thanks @rwegener2 ! The final version number is v0.5.3 (Civil Dawn) and the DOI to the Zenodo Archive repo is 10.5281/zenodo.14899662 (https://doi.org/10.5281/zenodo.14899662) |
@editorialbot set 10.5281/zenodo.14899662 as archive |
Done! archive is now 10.5281/zenodo.14899662 |
@editorialbot set v0.5.3 as version |
Done! version is now v0.5.3 |
@editorialbot generate pdf |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6447, then you can now move forward with accepting the submission by compiling again with the command |
Thank you again, @rwegener2, @cansavvy, and @welch16 for your work and insightful feedback! It is tremendous that this type of open review style is available! |
@JZauner as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. Below are some final checks, some of which may require your attention: Checks on repository
Checks on review issue
Checks on archive
Checks on paper
Remaining points:As you can see, most seems in order, however the below are some points that require your attention 👇 :
|
Thank you @Kevin-Mattheus-Moerman ! I changed the archive title, and also rephrased the paper to be BE. The updated paper is in the paper branch |
Hi @Kevin-Mattheus-Moerman. Do we have to check off the remaining points (if so, they do not seem to be available to me)? |
@JZauner apologies for the delay. I checked things just now and all is in order. I'll now proceed to process this for acceptance. Thanks. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Amazing! Thank you @Kevin-Mattheus-Moerman, @rwegener2, @cansavvy, @welch16 and JOSS! |
@JZauner congratulations on this JOSS publication! Thanks for editing @rwegener2 ! And a special thank you to the reviewers: @cansavvy, @welch16 !!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @JZauner (Johannes Zauner)
Repository: https://github.com/tscnlab/LightLogR
Branch with paper.md (empty if default branch): paper
Version: v0.5.3
Editor: @rwegener2
Reviewers: @cansavvy, @welch16
Archive: 10.5281/zenodo.14899662
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@cansavvy & @welch16, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rwegener2 know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @welch16
📝 Checklist for @cansavvy
The text was updated successfully, but these errors were encountered: