Skip to content

[PRE REVIEW]: UXsim: lightweight mesoscopic traffic flow simulator in pure Python #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Oct 8, 2024 · 43 comments
Assignees
Labels
pre-review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 8, 2024

Submitting author: @toruseo (Toru Seo)
Repository: https://github.com/toruseo/UXsim
Branch with paper.md (empty if default branch): JOSS
Version: v1.6.0
Editor: @kanishkan91
Reviewers: @fxjung, @Nitnelav
Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d6d109398597b438cb9b12a9f744346c"><img src="https://joss.theoj.org/papers/d6d109398597b438cb9b12a9f744346c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d6d109398597b438cb9b12a9f744346c/status.svg)](https://joss.theoj.org/papers/d6d109398597b438cb9b12a9f744346c)

Author instructions

Thanks for submitting your paper to JOSS @toruseo. Currently, there isn't a JOSS editor assigned to your paper.

@toruseo if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Oct 8, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (531.9 files/s, 59308.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Markdown                         2             49              0            178
TeX                              1             21              0            174
YAML                             1              1              4             19
-------------------------------------------------------------------------------
SUM:                             4             71              4            371
-------------------------------------------------------------------------------

Commit count by author:

   266	Toru Seo
    12	Ewout ter Hoeven
     1	dependabot[bot]

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1795

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

🔴 Failed to discover a valid open source license

@editorialbot
Copy link
Collaborator Author

@crvernon
Copy link

crvernon commented Oct 8, 2024

👋 @toruseo - Could you please provide a branch that has both the code of your repo and the paper components needed for JOSS within the same branch? This will help our editorialbot to find what it needs.

@toruseo
Copy link

toruseo commented Oct 9, 2024

@crvernon Sorry for my misunderstanding. Now branch JOSS has both of the paper and software code.

@Nitnelav
Copy link

Nitnelav commented Oct 9, 2024

Hi ! I'd be happy to volunteer as a reviewer if needed. I'm not a traffic engineer but I am using multi-agent mesoscopic traffic models in my work. It would be my first review here so i'll try to strictly follow the guidelines.

@crvernon
Copy link

crvernon commented Oct 9, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@crvernon
Copy link

crvernon commented Oct 9, 2024

Hi @Nitnelav, I'll keep that in mind when I get an editor assigned to this submission. How did you hear about this review by the way?

@crvernon
Copy link

crvernon commented Oct 9, 2024

@openjournals/dev can you help out the the PDF generation action failure above? Thanks!

@Nitnelav
Copy link

Hi @Nitnelav, I'll keep that in mind when I get an editor assigned to this submission. How did you hear about this review by the way?

Cool, thanks !

I had an eye on the joss-reviews issues for some time, looking for one I could volunteer to review. I was hipped about JOSS at an "open source in acoustics" workshop and I found the open submission and reviewing process on github very interesting. Then we (the UMRAE team) decided to submit our NoiseModelling software to JOSS (work is in progress). And so I thought I'd participate to the reviewing process to see how it goes !

@xuanxu
Copy link
Member

xuanxu commented Oct 10, 2024

The error in the PDF generation comes from this date in the paper's metadata not following the expected syntax .

toruseo added a commit to toruseo/UXsim that referenced this issue Oct 10, 2024
@toruseo
Copy link

toruseo commented Oct 10, 2024

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@toruseo
Copy link

toruseo commented Oct 10, 2024

It is fixed now. Thanks

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

TraViA: a Traffic data Visualization and Annotation tool in Python
Submitting author: @OlgerSiebinga
Handling editor: @danielskatz (Active)
Reviewers: @rusu24edward, @tomalrussell
Similarity score: 0.7272

RidePy: A fast and modular framework for simulating ridepooling systems
Submitting author: @fxjung
Handling editor: @diehlpk (Active)
Reviewers: @xoolive, @abhishektiwari, @ixjlyons
Similarity score: 0.7073

AirTrafficSim: An open-source web-based air traffic simulation platform.
Submitting author: @kyfrankie
Handling editor: @AoifeHughes (Retired)
Reviewers: @gmingas, @xoolive
Similarity score: 0.7008

TDLM: An R package for a systematic comparison of trip distribution laws and models
Submitting author: @maximelenormand
Handling editor: @crvernon (Active)
Reviewers: @kanishkan91, @MAnalytics
Similarity score: 0.6870

CoSApp: a Python library to create, simulate and design complex systems.
Submitting author: @elac-safran
Handling editor: @HaoZeke (Active)
Reviewers: @jbussemaker, @chenxinye
Similarity score: 0.6853

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@crvernon
Copy link

@editorialbot invite @kanishkan91 as editor

👋 @kanishkan91 - can you edit this one? Thanks!

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@kanishkan91
Copy link

@crvernon Yup, I can take this one

@crvernon
Copy link

@editorialbot assign @kanishkan91 as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kanishkan91 is now the editor

@toruseo
Copy link

toruseo commented Nov 5, 2024

@kanishkan91 Thank you very much for handling my paper.

Do I need to do something to advance the review process? Or should I just wait? Sorry for interrupting you. I understand that the editorial process take some time, but I am not familiar with this submission system.

@kanishkan91
Copy link

@toruseo I don't think anything is required from your side. Though if you had potential reviewers in mind (without a conflict of interest) feel free to post their GitHub IDs here. I plan on getting this review started within the next week.

@toruseo
Copy link

toruseo commented Nov 8, 2024

Thank you.

Regarding potential reviewers, Nitnelav kindly volunteered as a reviewer (pls see #7332 (comment) for his motivation).
The authors of the related papers and the paper cited by my manuscript would be also great.

@toruseo
Copy link

toruseo commented Dec 9, 2024

@kanishkan91 Could you please tell me the expected timeline for this pre-review?

@kanishkan91
Copy link

@toruseo Sorry, I've been a bit overloaded with editing assignments. I just got done with a JOSS paper a couple days ago. I will turn my attention to this one right away.

@kanishkan91
Copy link

@Nitnelav would you be interested in reviewing this paper and package for JOSS?

@kanishkan91
Copy link

kanishkan91 commented Dec 25, 2024

@maximelenormand, based on your previous paper, reviews, would you be interested in reviewing this paper for JOSS? Note that this in python rather than R

@kanishkan91
Copy link

@fxjung would you be interested in reviewing this paper for JOSS? It seems like a good fit given previous papers youve authored

@maximelenormand
Copy link

maximelenormand commented Dec 25, 2024 via email

@Nitnelav
Copy link

@Nitnelav would you be interested in reviewing this paper and package for JOSS?

Yes, I'm in. I will find some time in january.

@fxjung
Copy link

fxjung commented Dec 28, 2024

@fxjung would you be interested in reviewing this paper for JOSS? It seems like a good fit given previous papers youve authored

Sure, I'll also find some time in January.

@kanishkan91
Copy link

@editorialbot assign @fxjung as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@kanishkan91
Copy link

@editorialbot add @fxjung as reviewer

@editorialbot
Copy link
Collaborator Author

@fxjung added to the reviewers list!

@kanishkan91
Copy link

@editorialbot add @Nitnelav as reviewer

@editorialbot
Copy link
Collaborator Author

@Nitnelav added to the reviewers list!

@kanishkan91
Copy link

@Nitnelav , @fxjung - Thanks so much! I'l get the review started on another thread shortly

@kanishkan91
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7617.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review TeX Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

8 participants