-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: Tenta: Remote and Real-Time Sensor Network Management #7311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
|
@editorialbot generate pdf |
I added the research grant number to the manuscript. |
@editorialbot add @sash19 as reviewer |
@sash19 added to the reviewers list! |
@empicano, @sash19, @abhishektiwari, This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. For @sash19, @abhishektiwari - Both reviewers have checklists at the top of this thread (in that first comment) with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. As you are probably already aware, The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #7311 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. Thanks in advance and let me know if you have any questions!! |
Thank you @sash19 and @abhishektiwari for taking on the review, and thank you @kanishkan91 again for editing! |
Review checklist for @sash19Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @abhishektiwariConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@sash19 , @abhishektiwari Just wanted to check in. How's the review going thus far? I was hoping to get the initial reviews to the authors within the next couple of weeks. Do let me know if you need anything from my side. |
Hi, I should be able to complete review by early next week. |
Hi, I have reviewed Tenta! My main comments are below. Please feel free to follow up with me for additional reviews or discussions:
|
@kanishkan91 I have completed my checklist and review. The software addresses a clear need in sensor network management, particularly for research applications. The architecture is well-thought-out, emphasising flexibility and scalability. Good test coverage for both client and server. I recommend to accept the paper. Few Language NitpicksLine 11-12: "when these networks are more than a few sensors in scale and/or their locations difficult to access" Should be: "when these networks are more than a few sensors in scale and/or their locations are difficult to access" Line 31-32: The IoT space is dominated by proprietary services e.g. from Amazon and Microsoft Azure Something like: The IoT space is dominated by proprietary cloud services, e.g., from Amazon Web Services and Microsoft Azure. Line 89: "CO2 sensor network in munich." "Munich" should be capitalized Nonblocking commentsI know paper mentioned the real-world validation through deployment with 20 CO2 sensors. It will be great if that was shared as working example as part of repository or through a tutorial on documentation pages. This will reduce the friction for anyone trying to figure out use case of this software. Consider releasing dashboard as NPM package and server as Python module. This is mainly to reduce the friction to use/onboard to Tenta as well as introduce opportunities to extend core functionality via extension and plugins. This may require some change in API interfaces. |
@empicano The reviewers have added their initial comments. Could you take a look and p;ost some responses. In particular I would take a look at @sash19's comments regarding the installation process and how the same can be streamlined. After you post your responses and address the same on your repo, we can take it from there. |
Thank you @sash19 and thank you @abhishektiwari for your detailed reviews! @sash19: The tests can be run with the Thanks also for reporting about the difficulties with the setup. I've added a Docker Compose file that handles dependencies like Python 3.11 and poetry automatically, and updated the README with instructions on how to run Tenta with Docker Compose. @abhishektiwari: I adopted your wording suggestions verbatim. We've open-sourced the code of our CO2 sensor network as a real-word example and linked it in the documentation. Interesting idea to release Tenta as NPM package and Python module, too. This would indeed require some API changes, but you're right that the extensibility could be worth it. I will keep this in mind as future improvement. Please let me know if any further changes are needed. |
@empicano Thanks for the responses! I assume you made and merged a new PR with the updates? @abhishektiwari and @sash19 - Could you take a look at the revised repo and see if your comments are addressed? If so, could you complete your checklists? |
@editorialbot recommend-accept |
|
|
👋 @openjournals/ese-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6301, then you can now move forward with accepting the submission by compiling again with the command |
@empicano , @dostuffthatmatters I have recommended this for acceptance now. I will be reading through the paper for typos etc. shortly. The AEiC in this submission track will review shortly and if all goes well this will go live soon! Big thank you to @abhishektiwari and @sash19 for reviewing! JOSS is volunteer run and relies heavily on researchers such as yourself. If you are interested in reviewing for JOSS in the future, kindly register yourself at the reviewer hub here- https://reviewers.joss.theoj.org/ |
|
@editorialbot check references |
|
I added the correct DOI for Polars. |
Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!
|
@abhishektiwari Can you finish your review checklist if you are satisfied with this submission? Thank you! |
Please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file. For example, "munich" is not capitalized but please check all references carefully. |
Thank you @kthyng for double checking!
Good catch! I added brackets around "Munich" and "Swiss". |
@editorialbot generate pdf |
Ok the paper looks good. I'm thinking we're not going to hear back about the slightly unfinished checklist but it looks like @abhishektiwari's intention is that the review is finished. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on your new publication @empicano and @dostuffthatmatters! Many thanks to editor @kanishkan91 and to reviewers @abhishektiwari and @sash19 for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. Note we have a new tool for reviewers! You can go to https://joss.theoj.org/papers/reviewed_by/@your-github-username to see the JOSS submissions you have reviewed, and you can also copy a badge there with the number of your JOSS reviews. @empicano If you'd like to join JOSS as a reviewer, please sign up at https://reviewers.joss.theoj.org/join! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you @kanishkan91, @abhishektiwari, @sash19, and @kthyng for your efforts and expertise as reviewers and editors from my co-authors and me. It's very much appreciated. |
Congratulations!! Glad to be a part of this. Feel free to reach out for anything else which may be needed. |
Submitting author: @empicano (Felix Böhm)
Repository: https://github.com/iterize/tenta
Branch with paper.md (empty if default branch):
Version: v0.2.0
Editor: @kanishkan91
Reviewers: @abhishektiwari, @sash19
Archive: 10.5281/zenodo.14597567
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@abhishektiwari, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kanishkan91 know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @sash19
📝 Checklist for @abhishektiwari
The text was updated successfully, but these errors were encountered: