-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: Teaspoon: A Python Package for Topological Signal Processing #7243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: 🟡 License found: |
|
@editorialbot generate my checklist |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
Review checklist for @yossibokorbleileConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello @EduPH, here are the things you can ask me to do:
|
Review checklist for @EduPHConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hello @lizliz, thank you for such an excellent Python package. I am working on the review and added an issue in the repository about the needed version of the packages. |
👋 @lizliz what is the status with respect to the issues that were raised 4w ago by the reviewers? |
Hi, my apologies. End of the semester plus holidays here meant I haven't taken care of this. Hoping to get it done the first week of Dec if not before. I appreciate your patience! |
I also still need to provide more information sorry. Have been travelling and teaching. |
Hello folks! I have returned to the land of the living! I just took care of the requests from the reviewers (This issue which is now closed). Let me know what else I can do! And thanks again everyone for your time and patience. |
Hi @EduPH and @yossibokorbleile. I know I absolutely have no leg to stand on with this since I let it sit for a while, but is there anything else I can do for you for the review process? Thanks in advance! -Liz |
Hi @lizliz , thank you for following up! I’m currently at a conference this week, but this is one of my priorities for next week. I’ll get back to you soon. Thanks for your patience! |
Hey @lizliz |
okay, I'll bug you all in ~10 days (!) to see how it is going... |
Dear @lizliz, I have finished the review. Thank you for your nice work and the great contribution to the TDA community. @hugoledoux, all done from my side. |
@yossibokorbleile as promised, I am bugging you to see what is going one :) |
@hugoledoux |
Hi I have now finished my review. I opened another issue on the repo, but I don't think it should stop the review process. Overall the documentation is satisfactory, with maybe some places where extra examples would be beneficial. |
Thanks for the help, Yossi!! The bugs appear to have been squashed (see here). @hugoledoux what are the next steps? |
@editorialbot set 10.5281/zenodo.14989806 as archive |
Done! archive is now 10.5281/zenodo.14989806 |
@editorialbot set v1.5.23 as version |
Done! version is now v1.5.23 |
@editorialbot recommend-accept |
|
|
@yossibokorbleile @EduPH thanks for your help, without our reviewers JOSS wouldn't exist! @lizliz it's now accepted, but one final check needs to be done by one of the editor-in-chief, they might have some minor changes |
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6489, then you can now move forward with accepting the submission by compiling again with the command |
Thanks @hugoledoux ! This has been a lovely experience. I promise you're not rid of me yet, we have two more JOSS submissions coming down the pipe to send your way soon :D Extra thanks to @yossibokorbleile and @EduPH for the helpful feedback! |
As track editor, I will proofread this soon and let you know about any next steps on your part. |
I've suggested a number of small changes in TeaspoonTDA/teaspoon#169 - please merge this, or let me know what you disagree with, then we can continue to publishing the work. |
Fabulous, thank you! I fixed a small typo and pulled it into the branch. Let me know what else you need. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#6501, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🦋🦋🦋 👉 Bluesky post for this paper 👈 🦋🦋🦋 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @lizliz (Elizabeth Munch) and co-authors on your JOSS publication!! And thanks to @yossibokorbleile & @EduPH for reviewing, and to @hugoledoux for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @lizliz (Elizabeth Munch)
Repository: https://github.com/TeaspoonTDA/teaspoon
Branch with paper.md (empty if default branch): joss-paper
Version: v1.5.23
Editor: @hugoledoux
Reviewers: @yossibokorbleile, @EduPH
Archive: 10.5281/zenodo.14989806
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@yossibokorbleile & @EduPH, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @yossibokorbleile
📝 Checklist for @EduPH
The text was updated successfully, but these errors were encountered: