Skip to content

[PRE REVIEW]: FluidSF: A Python package for calculating turbulent flow statistics #7193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Sep 7, 2024 · 34 comments
Assignees
Labels
pre-review Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 7, 2024

Submitting author: @cassidymwagner (Cassidy Wagner)
Repository: https://github.com/cassidymwagner/fluidsf
Branch with paper.md (empty if default branch):
Version: v0.2.0
Editor: @philipcardiff
Reviewers: @ManuelRatz, @MaceKuailv
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a247752fccc0e1e4986996e5d5f67b0f"><img src="https://joss.theoj.org/papers/a247752fccc0e1e4986996e5d5f67b0f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a247752fccc0e1e4986996e5d5f67b0f/status.svg)](https://joss.theoj.org/papers/a247752fccc0e1e4986996e5d5f67b0f)

Author instructions

Thanks for submitting your paper to JOSS @cassidymwagner. Currently, there isn't a JOSS editor assigned to your paper.

@cassidymwagner if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Sep 7, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

⚠️ An error happened when generating the pdf. Problem with affiliations for Cassidy Wagner, perhaps the affiliations index need quoting?.

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1017/jfm.2021.247 is OK
- 10.1017/jfm.2018.528 is OK
- 10.21105/joss.02185 is OK
- 10.21105/joss.04277 is OK
- 10.1063/5.0107974 is OK
- 10.1038/s41586-020-2649-2 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Intermittency, coherent structures and dissipation...
- No DOI given, and none found for title: Dissipation of energy in the locally isotropic tur...
- No DOI given, and none found for title: Dissipation of energy in the locally isotropic tur...

❌ MISSING DOIs

- 10.1063/5.0028119 may be a valid DOI for title: Turbulence anisotropy and intermittency in open-ch...
- 10.1175/jtech-d-15-0180.1 may be a valid DOI for title: Evaluation of thermosalinograph and VIIRS data for...
- 10.1017/jfm.2014.685 may be a valid DOI for title: A Helmholtz decomposition of structure functions a...
- 10.1126/sciadv.abq2566 may be a valid DOI for title: Direct observational evidence of an oceanic dual k...
- 10.1029/2019jc015769 may be a valid DOI for title: Biases in structure functions from observations of...
- 10.1017/jfm.2021.247 may be a valid DOI for title: Advective structure functions in anisotropic two-d...
- 10.1017/s0022112099004851 may be a valid DOI for title: Can the atmospheric kinetic energy spectrum be exp...
- 10.1175/jpo-d-19-0107.1 may be a valid DOI for title: Small-scale dispersion in the presence of langmuir...
- 10.1175/jpo-d-18-0029.1 may be a valid DOI for title: Impacts of convergence on structure functions from...
- 10.1038/nphys4227 may be a valid DOI for title: Forward and inverse kinetic energy cascades in Jup...
- 10.1103/physrevfluids.5.054605 may be a valid DOI for title: Scaling exponents saturate in three-dimensional is...
- 10.17125/gov2018.ch08 may be a valid DOI for title: Fine-scale altimetry and the future SWOT mission
- 10.21105/joss.03053 may be a valid DOI for title: GeophysicalFlows. jl: Solvers for geophysical flui...

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (963.5 files/s, 158660.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          34            261            917           4031
Jupyter Notebook                10              0           2721           1293
YAML                             6             35             11            252
TeX                              1             21              0            230
reStructuredText                 7            117             95            116
Markdown                         2             40              0            112
TOML                             1              8              4             55
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            63            494           3756           6124
-------------------------------------------------------------------------------

Commit count by author:

   413	Cassidy Wagner
    87	Brodie Pearson
    14	BrodiePearson
    13	cassidymwagner
     1	Ara Lee

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 1095

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 7, 2024
@arfon
Copy link
Member

arfon commented Sep 7, 2024

@cassidymwagner - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@cassidymwagner
Copy link

@arfon Thank you for the update! In the meantime we'll take care of some of the errors the bot flagged 👍

@kyleniemeyer
Copy link

@editorialbot invite @philipcardiff as editor

Hi @philipcardiff, could you edit this one?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@philipcardiff
Copy link

@editorialbot invite @philipcardiff as editor

Hi @philipcardiff, could you edit this one?

Sure.

@philipcardiff
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @philipcardiff is now the editor

@cassidymwagner
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

FlowSieve: A Coarse-Graining Utility for Geophysical Flows on the Sphere
Submitting author: @bastorer
Handling editor: @kthyng (Active)
Reviewers: @NoraLoose, @ashwinvis
Similarity score: 0.7701

flowTorch - a Python library for analysis and reduced-order modeling of fluid flows
Submitting author: @AndreWeiner
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @akaptano, @JaroslavHron, @salrm8, @hkjeldsberg
Similarity score: 0.7402

SyntheticEddyMethod.jl: A Julia package for the creation of inlet flow conditions for LES
Submitting author: @carlodev
Handling editor: @philipcardiff (Active)
Reviewers: @atzberg, @akshaysridhar
Similarity score: 0.7360

Sapsan: Framework for Supernovae Turbulence Modeling with Machine Learning
Submitting author: @pikarpov-lanl
Handling editor: @dfm (Active)
Reviewers: @kburns, @milescranmer
Similarity score: 0.7173

SPICY: a Python toolbox for meshless assimilation from image velocimetry using radial basis functions
Submitting author: @mendezVKI
Handling editor: @philipcardiff (Active)
Reviewers: @nolankucd, @MatthewFlamm, @ctdegroot
Similarity score: 0.7156

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@cassidymwagner
Copy link

Hello @philipcardiff, thank you for taking on the role of editor for our paper! Here is a list of suggested reviewers:

  • Wenrui Jiang (MaceKuailv)
  • Benjamin Storer (bastorer)
  • Tomas Chor (tomchor)
  • Ali Ramadhan (ali-ramadhan)
  • Navid Constantinou (navidcy)

@kyleniemeyer kyleniemeyer removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Oct 24, 2024
@philipcardiff
Copy link

Hello @bastorer, would you be interested in reviewing this submission?

@philipcardiff
Copy link

Hello @tomchor, would you be interested in reviewing this submission?

@philipcardiff
Copy link

Hello @mendezVKI, would you be interested in reviewing this submission?

@philipcardiff
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1017/jfm.2021.247 is OK
- 10.1063/1.4945631 is OK
- 10.1063/5.0028119 is OK
- 10.1175/jtech-d-15-0180.1 is OK
- 10.1126/sciadv.abq2566 is OK
- 10.1017/s0022112099004851 is OK
- 10.1175/jpo-d-18-0029.1 is OK
- 10.1038/nphys4227 is OK
- 10.1103/physrevfluids.5.054605 is OK
- 10.21105/joss.02185 is OK
- 10.21105/joss.04277 is OK
- 10.1063/5.0107974 is OK
- 10.17125/gov2018.ch08 is OK
- 10.21105/joss.03053 is OK
- 10.1038/s41586-020-2649-2 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: A Novel Method to Estimate Spectral Fluxes in Quas...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@philipcardiff
Copy link

Hello @MaceKuailv, would you be interested in reviewing this submission?

@philipcardiff
Copy link

FYI, I have also emailed potential reviewers.

@philipcardiff
Copy link

Hello @navidcy, Would you be interested in reviewing the submission “ FluidSF: A Python package for calculating turbulent flow statistics,” which we received at JOSS? The submission link is #7193, and the repository is at https://github.com/cassidymwagner/fluidsf.

If you are unfamiliar with JOSS, the review process is unique: it takes place in a GitHub issue, is open, and encourages author-reviewer-editor conversations. To get an idea of what is expected, you can look at our review criteria (https://joss.readthedocs.io/en/latest/review_criteria.html) and review checklist (https://joss.readthedocs.io/en/latest/review_checklist.html).

@MaceKuailv
Copy link

@philipcardiff I am happy to do it

@philipcardiff
Copy link

@editorialbot add @ManuelRatz as reviewer

@editorialbot
Copy link
Collaborator Author

@ManuelRatz added to the reviewers list!

@philipcardiff
Copy link

@editorialbot add @MaceKuailv as reviewer

@editorialbot
Copy link
Collaborator Author

@MaceKuailv added to the reviewers list!

@philipcardiff
Copy link

@philipcardiff I am happy to do it

Thanks!

@philipcardiff
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7873.

@philipcardiff
Copy link

We can continue the conversation over on the review issue: #7873.

If other invited reviewers are available, please let me know, and I will add you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pre-review Track: 3 (PE) Physics and Engineering
Projects
None yet
Development

No branches or pull requests

6 participants