[PRE REVIEW]: TurboFlow: Meanline Modelling of Turbomachinery

[editorialbot]

Submitting author: @lasseband (Lasse Borg Anderson)
Repository: https://github.com/turbo-sim/TurboFlow
Branch with paper.md (empty if default branch):
Version: v0.1.11
Editor: @philipcardiff
Reviewers: @salehisaeed, @aromei
Managing EiC: Kyle Niemeyer

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/012c28a652c451c61c7400c3a68787d2"><img src="https://joss.theoj.org/papers/012c28a652c451c61c7400c3a68787d2/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/012c28a652c451c61c7400c3a68787d2/status.svg)](https://joss.theoj.org/papers/012c28a652c451c61c7400c3a68787d2)

Author instructions

Thanks for submitting your paper to JOSS @lasseband. Currently, there isn't a JOSS editor assigned to your paper.

@lasseband if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1115/1.4023122 is OK
- 10.1115/1.4037819 is OK
- 10.1115/GT2005-68716 is OK
- 10.3390/ijtpp4030032 is OK

MISSING DOIs

- 10.1016/c2009-0-20205-4 may be a valid DOI for title: Fluid mechanics and thermodynamics of turbomachine...
- No DOI given, and none found for title: Organic rankine cycle (ORC) power systems : techno...
- 10.2514/6.2016-0119 may be a valid DOI for title: Meanline Analysis of Turbines with Choked Flow in ...
- No DOI given, and none found for title: Turboflow: Mean-Line Modelling of Axial Turbines
- No DOI given, and none found for title: CFturbo
- No DOI given, and none found for title: AxSTREAM
- No DOI given, and none found for title: TURBOdesign Suite
- No DOI given, and none found for title: Concepts NREC
- No DOI given, and none found for title: turbigen

INVALID DOIs

- None

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.25 s (830.7 files/s, 250573.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              5              2             46          23906
Python                          90           4329           8896          12083
YAML                            40            354             93           5288
TeX                              2            126              0           1260
reStructuredText                59           1490           2902            922
Markdown                         6            117              0            495
TOML                             1              4              0             39
JSON                             1              0              0             29
DOS Batch                        1              8              1             26
make                             1              4              7              9
CSS                              1              0              0              4
-------------------------------------------------------------------------------
SUM:                           207           6434          11945          44061
-------------------------------------------------------------------------------

Commit count by author:

   217	laboan
   144	roagr
    86	Lasse borg anderson
     4	Roberto Agromayor

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1006

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

flowTorch - a Python library for analysis and reduced-order modeling of fluid flows
Submitting author: @AndreWeiner
Handling editor: @Kevin-Mattheus-Moerman (Active)
Reviewers: @akaptano, @JaroslavHron, @salrm8, @hkjeldsberg
Similarity score: 0.7158

RHEIA: Robust design optimization of renewable Hydrogen and dErIved energy cArrier systems
Submitting author: @DCoppitters
Handling editor: @fraukewiese (Active)
Reviewers: @andr1976, @ClaraBuettner
Similarity score: 0.6954

ROSS - Rotordynamic Open Source Software
Submitting author: @raphaeltimbo
Handling editor: @meg-simula (Retired)
Reviewers: @srmnitc, @nnadeau
Similarity score: 0.6953

SHARPy: A dynamic aeroelastic simulation toolbox for very flexible aircraft and wind turbines
Submitting author: @fonsocarre
Handling editor: @labarba (Retired)
Reviewers: @petebachant, @rafmudaf
Similarity score: 0.6942

OpenOA: An Open-Source Codebase For Operational Analysis of Wind Farms
Submitting author: @jordanperr
Handling editor: @sjpfenninger (Retired)
Reviewers: @gschivley, @brynpickering
Similarity score: 0.6922

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

[kyleniemeyer]

Hi @lasseband, unfortunately we do not have an editor available to handle your submission right now, and I have to put this on the waitlist.

In the meantime, please take a look at those missing DOI warnings for the paper, and any reviewer recommendations you can make would be welcome.

[lasseband]

Hi @kyleniemeyer,

Thank you for the notification. I will check the DOI warnings and look for potential reviewers.

[lasseband]

Hi again @kyleniemeyer

I have reviewed the DOI warnings and corrected several issues. Most references lacking DOIs do not have an associated DOI, but I have added the ones that do.

Additionally, we have discussed potential reviewers and have a few suggestions. Although none of our suggestions are on the list of people who have already agreed to review, we still believe they would be suitable candidates.

• Alfonso del Carre, Skydweller Aero Arbea Campus, Madrid, Spain (Note: Alfonso del Carre is the author of one of the most similar publications.)
• Lasse Mueller, Von Karman Institute for Fluid Dynamics, Rhode-Saint-Genese, Belgium
• Tim Albring, Rheinland-Pfälzische Technische Universität Kaiserslautern-Landau, Kaiserslautern, Germany

Hope this helps in finding suitable reviewers.

[lasseband]

Hi again @kyleniemeyer,

Any updates on the editor issue? Or do you have any idea how long it may take until you find an editor?

[kyleniemeyer]

@lasseband the issue isn't really finding an editor, it's just that our editorial board is already at capacity handling other submissions.

[kyleniemeyer]

Hi @AnjaliSandip and @philipcardiff, would either one of you be willing to handle one additional submission? This was submitted about two months ago. Thanks!

[philipcardiff]

Hi @kyleniemeyer, sorry for my delayed reply (September is a busy time at University!). I can take this one.

[philipcardiff]

@editorialbot assign me as editor

[editorialbot]

Assigned! @philipcardiff is now the editor

[philipcardiff]

Hi @lasseband, thanks for the reviewer suggestions.

Before I invite them, where can I find the documentation for TurboFlow? I don't see it mentioned at https://github.com/turbo-sim/TurboFlow (apologies if I missed it).

Philip

[lasseband]

Hi @philipcardiff

Thanks for being able to handle our submission.

The documentation can be found here: https://turbo-sim.github.io/turboflow/
The link is contained in the README file, and can be accessed by pressing the "docs latest" badge link.

Lasse

[philipcardiff]

Thanks @lasseband,

Ah OK. A documentation link as a badge is reasonable, but some users might overlook it (like "slow-witted me :D). For better clarity, it would be helpful to also include an explicit link to the documentation in a clearly labeled section, such as "Getting Started" or "Documentation," in addition to the badge. This ensures that users can easily find the information they need without relying solely on badges.

[philipcardiff]

Hello @fonsocarre, Would you be interested in reviewing the submission “TurboFlow: Meanline Modelling of Turbomachinery,” which we received at JOSS? The submission link is #6979, and the repository is at https://turbo-sim.github.io/turboflow/.

If you are unfamiliar with JOSS, the review process is unique: it takes place in a GitHub issue, is open, and encourages author-reviewer-editor conversations. To get an idea of what is expected, you can look at our review criteria (https://joss.readthedocs.io/en/latest/review_criteria.html) and review checklist (https://joss.readthedocs.io/en/latest/review_checklist.html).

[philipcardiff]

FYI, I emailed Lasse Mueller.

[philipcardiff]

And I emailed another potential reviewer.

[philipcardiff]

@editorialbot add @salehisaeed as reviewer

[editorialbot]

@salehisaeed added to the reviewers list!

[lasseband]

Hi @philipcardiff,

I apologize for the delayed response. I added an explicit link to the documentation in the README file under "Core features", so it should be easier to find it now :D.

Thanks for adding the reviewers. I look forward to addressing any feedback that comes in to help improve our work.

[philipcardiff]

HI @raphaeltimbo, would you be interested in reviewing this submission?

[philipcardiff]

Hi @talbring, Would you be interested in reviewing the submission “TurboFlow: Meanline Modelling of Turbomachinery,” which we received at JOSS? The submission link is #6979, and the repository is at https://turbo-sim.github.io/turboflow/.

If you are unfamiliar with JOSS, the review process is unique: it takes place in a GitHub issue, is open, and encourages author-reviewer-editor conversations. To get an idea of what is expected, you can look at our review criteria (https://joss.readthedocs.io/en/latest/review_criteria.html) and review checklist (https://joss.readthedocs.io/en/latest/review_checklist.html).

[philipcardiff]

FYI, I emailed a potential reviewer.

[philipcardiff]

HI @raphaeltimbo, would you be interested in reviewing this submission?

HI @raphaeltimbo, a reminder about this; please let us know if you are available.

[philipcardiff]

Hi @jordanperr, would you be interested in reviewing this submission?

[raphaeltimbo]

HI @raphaeltimbo, would you be interested in reviewing this submission?

HI @raphaeltimbo, a reminder about this; please let us know if you are available.

Hi @philipcardiff
Unfortunately, I will not be able to review this submission.

[lasseband]

Hi @philipcardiff,

We have contacted a potential reviewer who agreed to participate. His experience within turbomachinery and meanline modeling makes him suitable for this review. Could you contact him and add him to this issue?
Name: Alessandro Romei
Affiliation: Politecnico di Milano

Do we need any additional reviewers?

Best,
Lasse

[philipcardiff]

Thanks, Lasse. Yes, I will contact Alessandro.

[philipcardiff]

@editorialbot add @aromei as reviewer

[editorialbot]

@aromei added to the reviewers list!

[philipcardiff]

@editorialbot start review

[editorialbot]

OK, I've started the review over in #7588.

[philipcardiff]

Hi all, we can continue the review over on the review issue #7588.