-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: Arabica: A Python package for exploratory analysis of text data #6186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋 Hi @linuxscout, @amitkumarj441, thank you so much for helping out at JOSS. If you need any pointers, please feel free to look at previous reviews (which can be found by looking at published papers) and the documentation. If you need to comment on the code itself, opening an issue at the repo and then linking to it from here (to help me/others keep track) is the way to go. For comments on the paper, you can also open issues or PRs (say for typos), but those can be directly posted as replies in this issue. Thanks, and feel free to reach out if you need me. |
can you check the missing DOI @PetrKorab, please? |
Review checklist for @linuxscoutConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@oliviaguest I've added DOI for PyArabic: A Python package for Arabic text. |
Review checklist for @amitkumarj441Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I believe the reference to this package, PyArabic, is inappropriate for this work because PyArabic is a modest library for basic Arabic text functionality. I recommend citing more complex text processing frameworks or data visualizations. |
@PetrKorab |
@linuxscout @oliviaguest Thanks. Should I revise the paper now ?
|
I give my Ok for this paper. |
automated tests are provided and the issue is closed. |
@linuxscout thank you so much. |
@oliviaguest Hi, may I ask what's the current status of the submission? |
I believe @amitkumarj441 has not completed the checklist yet? |
@oliviaguest Thanks for the reminder. I have been reviewing this codebase earlier in mid Feb but kind of busy with other commitments and due to no notifications, It just slipped from my schedule. I will send my reviews soon. |
@editorialbot check references |
|
@amitkumarj441 what's a sensible ETA for your review? |
I was able to run the python tests without any issue and most of the functionalities in the examples work well, though, I suggest checking the compatibility among the dependencies, such as the requirement for installing this should be at least Python 3.8.x. However, it is Python 3.9 in setup.py, I suggest fixing @PetrKorab I suggest fixing the missing DOIs as well. |
@editorialbot check references |
@editorialbot generate pdf |
@oliviaguest I made these updates, thanks. |
@PetrKorab OK, I think I will do a PR to explain. Perhaps it's just that you have not seen this type of citation format previously. |
Let me know if this is clear: PetrKorab/Arabica#12 and/or just merge it. Thanks. What else is left to do? |
|
OK, so once that PR is dealt with can you make sure the version is OK? I see pypi has 1.7.7 but above is 1.7.1, which is right for JOSS? Otherwise, we're good to go. 😊 |
@oliviaguest Many thanks for the explanation. Yes, I came from the Economics field where the citation system is a bit different. For JOSS, 1.7.7 is correct. Thanks ! :) |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5306, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Huge thanks to the reviewers (@linuxscout, @amitkumarj441)! ✨ JOSS appreciates your work and effort. ✨ Also, big congratulations to the author(s), @PetrKorab! 🥳 🍾 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@oliviaguest @linuxscout @amitkumarj441 |
Submitting author: @PetrKorab (Petr Koráb)
Repository: https://github.com/PetrKorab/Arabica
Branch with paper.md (empty if default branch): main
Version: 1.7.1
Editor: @oliviaguest
Reviewers: @linuxscout, @amitkumarj441
Archive: 10.5281/zenodo.10866696
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@linuxscout & @amitkumarj441, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @oliviaguest know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @linuxscout
📝 Checklist for @amitkumarj441
The text was updated successfully, but these errors were encountered: