Skip to content

[REVIEW]: Raphtory: The temporal graph engine for Rust and Python #5940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Oct 11, 2023 · 60 comments
Closed

[REVIEW]: Raphtory: The temporal graph engine for Rust and Python #5940

editorialbot opened this issue Oct 11, 2023 · 60 comments
Assignees
Labels
accepted Dockerfile HTML published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Rust Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Oct 11, 2023

Submitting author: @narnolddd (Naomi Arnold)
Repository: https://github.com/Pometry/Raphtory
Branch with paper.md (empty if default branch): paper
Version: 0.7.0
Editor: @luizirber
Reviewers: @abhishektiwari, @arashbm
Archive: 10.5281/zenodo.10530613

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1fbaaa72bc711cee778c7eca04530286"><img src="https://joss.theoj.org/papers/1fbaaa72bc711cee778c7eca04530286/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1fbaaa72bc711cee778c7eca04530286/status.svg)](https://joss.theoj.org/papers/1fbaaa72bc711cee778c7eca04530286)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@abhishektiwari & @arashbm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @luizirber know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @arashbm

📝 Checklist for @abhishektiwari

@editorialbot editorialbot added Dockerfile HTML Python review Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning labels Oct 11, 2023
@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.36 s (968.0 files/s, 185049.1 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
Rust                            233           5321           4739          36105
Python                           26            871            420           4342
JSON                             15              0              0           3823
YAML                             24             43             21           1174
Jupyter Notebook                 11              0           5845           1113
Markdown                          8            258              0            658
TOML                             13             64             24            357
CSS                               2             65             11            276
TeX                               1             27              0            269
SVG                               1              0              0            155
JavaScript                        3             11              4             55
make                              2             13              7             31
DOS Batch                         1              8              1             26
Dockerfile                        1             14              0             26
HTML                              3              0              0             23
Bourne Shell                      1              6              0             17
reStructuredText                  1             35             42             14
Bourne Again Shell                1              3              3             12
--------------------------------------------------------------------------------
SUM:                            347           6739          11117          48476
--------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1308

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/19M1242252 is OK
- 10.1145/1852658.1852661 is OK
- 10.1209/0295-5075/81/48002 is OK
- 10.1103/physrevlett.110.198701 is OK
- 10.1016/j.future.2019.08.022 is OK
- 10.1016/j.softx.2022.101301 is OK
- 10.1145/3442442.3452052 is OK
- 10.5281/zenodo.7682609 is OK
- 10.6084/m9.figshare.1164194.v14 is OK
- 10.1103/PhysRevE.85.056115 is OK
- 10.1073/pnas.0903215107 is OK
- 10.1063/1.2711640 is OK
- 10.1145/3159652.3159706 is OK
- 10.1038/srep00397 is OK
- 10.1214/18-aoas1176 is OK
- 10.1073/pnas.0800332105 is OK
- 10.1038/s41567-019-0459-y is OK
- 10.1093/oso/9780198805090.001.0001 is OK
- 10.1007/978-3-642-36461-7 is OK
- 10.1142/q0033 is OK
- 10.1145/3479591 is OK
- 10.1145/3018661.3018731 is OK
- 10.1145/3093742.3093913 is OK
- 10.5281/zenodo.8009585 is OK
- 10.1101/2021.03.26.437187 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arashbm
Copy link

arashbm commented Oct 11, 2023

Review checklist for @arashbm

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/Pometry/Raphtory?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@narnolddd) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@abhishektiwari
Copy link

abhishektiwari commented Oct 11, 2023

Review checklist for @abhishektiwari

Conflict of interest

  • I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

General checks

  • Repository: Is the source code for this software available at the https://github.com/Pometry/Raphtory?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Contribution and authorship: Has the submitting author (@narnolddd) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
  • Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
  • Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
  • Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
  • Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
  • A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
  • State of the field: Do the authors describe how this software compares to other commonly-used packages?
  • Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
  • References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

@abhishektiwari
Copy link

@narnolddd please see initial feedback.

General checks

Contribution and authorship

— I was unable to find GitHub commits from Matt Barnes on Raphtory. Can you please comment on Matt's contribution for this paper and software?

Documentation

Installation instructions

Please add guidance for Python and Rust version supported. Also specify version requirements for examples either in folder readme or as an inline comment.

Example usage

A tried many of the examples, and they seem to be outdated and broken (1).

For instance, due to unclear guidance on what Python versions are supported, I started with 3.11.4 and have to make several modifications to get NFT Python example working. Opened a few tickets based on examples 2. I would like to see at-least Python LOTR example working.

Software paper

Quality of writing

Small corrections,

platform not platformß
Similarly, DyNetX not Similarly DyNetX

State of field

I am curious how Raphtory compares with graph databases such as arangodb/neo4j/MemGraph? I can see comparison benchmark data and scripts providing data points against MemGraph but no mention in the paper itself how Raphtory stack up against graph databases.

@arashbm
Copy link

arashbm commented Oct 30, 2023

Just a quick feedback on the paper: Great work, smooth installation, and enjoyable use. The manuscript is concise and checks all the right boxes. My only gripe is with the examples.

  • The examples are not self-contained. I understand that more involved use cases might be hard to condense to a few lines of code but I think they should still be run-able on their own. For example, it is not immediately clear where enron in example one and global_temporal_three_node_motifs in the third example are imported from. Example three, however, imports local_temporal_three_node_motifs and never uses it.
  • It would be better if the examples would become more readable. I leave that to the discretion of the authors, but I would recommend smaller output figures and paddings in exchange for larger font sizes. Remember that for someone browsing the paper that might be their first point of contact with the software. It is a chance for you to show its elegance and ease of use.

(Just to throw my unasked-for opinion in the mix, I don't believe that the manuscript would be the best place to publish benchmark results or even extensive comparison with other software, as these are often rapidly changing and highly sensitive to methodology and environment, thus not very reproducible. It's fine if there are benchmarks on the website, where they can be updated frequently but the paper might not be the best venue. Comparison to other software in the manuscript is better limited to differences in the general approach or difference in goals or stating their particular fields of specialisation.)

@narnolddd
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arashbm
Copy link

arashbm commented Nov 26, 2023

@narnolddd I don't seem to be able to run from raphtory.plottingutils import global_motif_heatplot from the examples. Is this the API for the next version or am I missing something on my setup?

@narnolddd
Copy link

Hi @arashbm , so sorry I should have added a comment earlier, when I regenerated the pdf it was because I was struggling a bit with the package to do it locally (have managed to do it now) and wasn't ready to read. Hope I didn't waste too much of your time with this! The code referenced in the example is at the moment just on a branch which is going to be merged today and will be put into the next release. I also have a reply to both reviews which I will share once that's in. Apologies again for this and thank you for all your time reading/testing the code and the feedback you've given already.

@narnolddd
Copy link

Raphtory review response

Hi @arashbm @abhishektiwari Happy New Year and thank you very much for your time and feedback on the paper. Apologies for the delay in getting back to you, there were a few other changes (unrelated to this submission) that needed to be made/fixed in the repository before we could push a release. This has now been done (Raphtory 0.7.0) as well as the requested changes to the manuscript and README. We have addressed the comments point by point below, but in summary have:

  • removed references to outdated examples in the readme and brought the existing examples up to date
  • made the examples in the paper more self-contained, easier to follow and with more generous font sizes
  • added instructions for the correct Python/Rust versions
  • fixed some small grammatical errors/typos

Response to comments from Abhishek

I was unable to find GitHub commits from Matt Barnes on Raphtory. Can you please comment on Matt's contribution for this paper and software?

Matt may not have committed directly to Raphtory but has been working on some of the academic/research use cases for the software and his input has been crucial for the design of new features (as is the case for some other authors on the paper).

Please add guidance for Python and Rust version supported. Also specify version requirements for examples either in folder readme or as an inline comment.

Thanks, we have now added the Python and Rust version requirement in the README (>=3.8 and >=1.75 respectively).

I tried many of the examples, and they seem to be outdated and broken (1).
For instance, due to unclear guidance on what Python versions are supported, I started with 3.11.4 and have to make several modifications to get NFT Python example working. Opened a few tickets based on examples 2. I would like to see at-least Python LOTR example working.

Apologies for this, they had become out of date and should have been deleted as we had got new versions working elsewhere. We now have one self-contained and comprehensive example (Sociopatterns baboon dataset) for Python.

Small corrections

Thank you for spotting those typos, these have now been fixed.

I am curious how Raphtory compares with graph databases such as arangodb/neo4j/MemGraph? I can see comparison benchmark data and scripts providing data points against MemGraph but no mention in the paper itself how Raphtory stack up against graph databases.

This is definitely something would like to address in a longer-form paper to give it an in-depth treatment, both due to the space resrictions of the JOSS format and because JOSS' scope seemed to be more focused on highlighting features and general usefulness than performance testing.

Response to comments from Arash

The examples are not self-contained. I understand that more involved use cases might be hard to condense to a few lines of code but I think they should still be run-able on their own. For example, it is not immediately clear where enron in example one and global_temporal_three_node_motifs in the third example are imported from. Example three, however, imports local_temporal_three_node_motifs and never uses it.

Thanks for your feedback. We have tried to make them a little more contained -- they are not entirely independent but assuming the user is familiar with Pandas and Matplotlib it should be clearer now where things are coming from:

  • In the first example, we have shown that enron is a dataframe read from a csv with given column names.
  • We made a small python module called plottingutils within Raphtory so that some of the more complicated plots like the motif one with the pictures on the axes can be done out of the box. For example 3 we have imported some functions from there so it is hopefully a bit clearer.
  • The only bit we have left the user to fill in the blanks with is plotting_function in example 2 due to space reasons, this is some boilerplate pandas/matplotlib code for plotting multiple columns of a dataframe which is simple enough but takes up a lot of space and this was the only way we could think of to get around it. Hoping it might be obvious enough for a user to proceed but would welcome any suggestions.

It would be better if the examples would become more readable. I leave that to the discretion of the authors, but I would recommend smaller output figures and paddings in exchange for larger font sizes. Remember that for someone browsing the paper that might be their first point of contact with the software. It is a chance for you to show its elegance and ease of use.

Thanks, we agree. We have tried to adjust the spacing a bit to make the fonts larger and allow for some gaps between logical sections of the code (balanced against keping the examples self-contained).

@narnolddd
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arashbm
Copy link

arashbm commented Jan 15, 2024

Thanks! I'm quite happy with the manuscript and the revisions completely resolve the minor issues I had with the previous version.

Great work!

@abhishektiwari
Copy link

@narnolddd Revised manuscript and updates look great. Look forward to Raphtory being used both in academia and industry. Thanks to everyone who has work on the software and paper.

@luizirber Review checklist is now complete from my side. Please let me know if anything else needed.

@luizirber
Copy link

Awesome, thanks @arashbm and @abhishektiwari for the fantastic reviews!

@luizirber
Copy link

luizirber commented Jan 18, 2024

Post-Review Checklist for Editor and Authors

Additional Author Tasks After Review is Complete

  • Double check authors and affiliations (including ORCIDs)
  • Make a release of the software with the latest changes from the review and post the version number here. This is the version that will be used in the JOSS paper.
  • Archive the release on Zenodo/figshare/etc and post the DOI here.
  • Make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper.
  • Make sure that the license listed for the archive is the same as the software license.

Editor Tasks Prior to Acceptance

  • Read the text of the paper and offer comments/corrections (as either a list or a PR)
  • Check the references in the paper for corrections (e.g. capitalization)
  • Check that the archive title, author list, version tag, and the license are correct
  • Set archive DOI with @editorialbot set <DOI here> as archive
  • Set version with @editorialbot set <version here> as version
  • Double check rendering of paper with @editorialbot generate pdf
  • Specifically check the references with @editorialbot check references and ask author(s) to update as needed
  • Recommend acceptance with @editorialbot recommend-accept

@luizirber
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/19M1242252 is OK
- 10.1145/1852658.1852661 is OK
- 10.1209/0295-5075/81/48002 is OK
- 10.1103/physrevlett.110.198701 is OK
- 10.1016/j.future.2019.08.022 is OK
- 10.48550/arXiv.2303.11181 is OK
- 10.1016/j.softx.2022.101301 is OK
- 10.1145/3442442.3452052 is OK
- 10.5281/zenodo.7682609 is OK
- 10.6084/m9.figshare.1164194.v14 is OK
- 10.1103/PhysRevE.85.056115 is OK
- 10.1073/pnas.0903215107 is OK
- 10.1063/1.2711640 is OK
- 10.1145/3159652.3159706 is OK
- 10.1038/srep00397 is OK
- 10.1214/18-aoas1176 is OK
- 10.1073/pnas.0800332105 is OK
- 10.1038/s41567-019-0459-y is OK
- 10.1093/oso/9780198805090.001.0001 is OK
- 10.1007/978-3-642-36461-7 is OK
- 10.1142/q0033 is OK
- 10.1145/3479591 is OK
- 10.1145/3018661.3018731 is OK
- 10.1145/3093742.3093913 is OK
- 10.5281/zenodo.8009585 is OK
- 10.1101/2021.03.26.437187 is OK
- 10.21105/joss.05872 is OK

MISSING DOIs

- No DOI given, and none found for title: Centralities in complex networks
- No DOI given, and none found for title: Dynamic network analysis in Julia
- No DOI given, and none found for title: Exploring network structure, dynamics, and functio...
- No DOI given, and none found for title: RecallGraph

INVALID DOIs

- None

@luizirber
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@luizirber
Copy link

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/19M1242252 is OK
- 10.1145/1852658.1852661 is OK
- 10.1209/0295-5075/81/48002 is OK
- 10.1103/physrevlett.110.198701 is OK
- 10.1016/j.future.2019.08.022 is OK
- 10.48550/arXiv.2303.11181 is OK
- 10.1016/j.softx.2022.101301 is OK
- 10.1145/3442442.3452052 is OK
- 10.5281/zenodo.7682609 is OK
- 10.6084/m9.figshare.1164194.v14 is OK
- 10.1103/PhysRevE.85.056115 is OK
- 10.1073/pnas.0903215107 is OK
- 10.1063/1.2711640 is OK
- 10.1145/3159652.3159706 is OK
- 10.1038/srep00397 is OK
- 10.1214/18-aoas1176 is OK
- 10.1073/pnas.0800332105 is OK
- 10.1038/s41567-019-0459-y is OK
- 10.1093/oso/9780198805090.001.0001 is OK
- 10.1007/978-3-642-36461-7 is OK
- 10.1142/q0033 is OK
- 10.1145/3479591 is OK
- 10.1145/3018661.3018731 is OK
- 10.1145/3093742.3093913 is OK
- 10.5281/zenodo.8009585 is OK
- 10.1101/2021.03.26.437187 is OK
- 10.21105/joss.05872 is OK

MISSING DOIs

- No DOI given, and none found for title: Centralities in complex networks
- No DOI given, and none found for title: Dynamic network analysis in Julia
- No DOI given, and none found for title: Exploring network structure, dynamics, and functio...
- No DOI given, and none found for title: RecallGraph

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5178, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@editorialbot editorialbot added the recommend-accept Papers recommended for acceptance in JOSS. label Mar 26, 2024
@arfon
Copy link
Member

arfon commented Mar 27, 2024

@narnolddd – could you please merge this PR? Pometry/Raphtory#1551

@narnolddd
Copy link

Thanks @arfon , merged!

@arfon
Copy link
Member

arfon commented Mar 27, 2024

@editorialbot recommend-accept

@editorialbot
Copy link
Collaborator Author

Attempting dry run of processing paper acceptance...

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/19M1242252 is OK
- 10.1145/1852658.1852661 is OK
- 10.1209/0295-5075/81/48002 is OK
- 10.1103/physrevlett.110.198701 is OK
- 10.1016/j.future.2019.08.022 is OK
- 10.48550/arXiv.2303.11181 is OK
- 10.1016/j.softx.2022.101301 is OK
- 10.1145/3442442.3452052 is OK
- 10.5281/zenodo.7682609 is OK
- 10.6084/m9.figshare.1164194.v14 is OK
- 10.1103/PhysRevE.85.056115 is OK
- 10.1073/pnas.0903215107 is OK
- 10.1063/1.2711640 is OK
- 10.1145/3159652.3159706 is OK
- 10.1038/srep00397 is OK
- 10.1214/18-aoas1176 is OK
- 10.1073/pnas.0800332105 is OK
- 10.1038/s41567-019-0459-y is OK
- 10.1093/oso/9780198805090.001.0001 is OK
- 10.1007/978-3-642-36461-7 is OK
- 10.1142/q0033 is OK
- 10.1145/3479591 is OK
- 10.1145/3018661.3018731 is OK
- 10.1145/3093742.3093913 is OK
- 10.5281/zenodo.8009585 is OK
- 10.1101/2021.03.26.437187 is OK
- 10.21105/joss.05872 is OK

MISSING DOIs

- No DOI given, and none found for title: Centralities in complex networks
- No DOI given, and none found for title: Dynamic network analysis in Julia
- No DOI given, and none found for title: Exploring network structure, dynamics, and functio...
- No DOI given, and none found for title: RecallGraph

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👋 @openjournals/dsais-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5184, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@arfon
Copy link
Member

arfon commented Mar 27, 2024

@editorialbot accept

@editorialbot
Copy link
Collaborator Author

Doing it live! Attempting automated processing of paper acceptance...

@editorialbot
Copy link
Collaborator Author

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Steer
  given-names: Ben
  orcid: "https://orcid.org/0000-0001-9446-5690"
- family-names: Arnold
  given-names: Naomi A.
  orcid: "https://orcid.org/0000-0001-6396-4788"
- family-names: Ba
  given-names: Cheick Tidiane
  orcid: "https://orcid.org/0000-0002-4035-7464"
- family-names: Lambiotte
  given-names: Renaud
  orcid: "https://orcid.org/0000-0002-0583-4595"
- family-names: Yousaf
  given-names: Haaroon
  orcid: "https://orcid.org/0000-0001-5098-5811"
- family-names: Jeub
  given-names: Lucas
  orcid: "https://orcid.org/0000-0001-8941-9227"
- family-names: Murariu
  given-names: Fabian
- family-names: Kapoor
  given-names: Shivam
- family-names: Rico
  given-names: Pedro
  orcid: "https://orcid.org/0000-0002-4698-8435"
- family-names: Chan
  given-names: Rachel
- family-names: Chan
  given-names: Louis
- family-names: Alford
  given-names: James
- family-names: Clegg
  given-names: Richard G.
  orcid: "https://orcid.org/0000-0001-7241-6679"
- family-names: Cuadrado
  given-names: Felix
  orcid: "https://orcid.org/0000-0002-5745-1609"
- family-names: Barnes
  given-names: Matthew Russell
- family-names: Zhong
  given-names: Peijie
- family-names: Pougué-Biyong
  given-names: John
  orcid: "https://orcid.org/0000-0002-6582-193X"
- family-names: Alnaimi
  given-names: Alhamza
contact:
- family-names: Arnold
  given-names: Naomi A.
  orcid: "https://orcid.org/0000-0001-6396-4788"
doi: 10.5281/zenodo.10530613
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Steer
    given-names: Ben
    orcid: "https://orcid.org/0000-0001-9446-5690"
  - family-names: Arnold
    given-names: Naomi A.
    orcid: "https://orcid.org/0000-0001-6396-4788"
  - family-names: Ba
    given-names: Cheick Tidiane
    orcid: "https://orcid.org/0000-0002-4035-7464"
  - family-names: Lambiotte
    given-names: Renaud
    orcid: "https://orcid.org/0000-0002-0583-4595"
  - family-names: Yousaf
    given-names: Haaroon
    orcid: "https://orcid.org/0000-0001-5098-5811"
  - family-names: Jeub
    given-names: Lucas
    orcid: "https://orcid.org/0000-0001-8941-9227"
  - family-names: Murariu
    given-names: Fabian
  - family-names: Kapoor
    given-names: Shivam
  - family-names: Rico
    given-names: Pedro
    orcid: "https://orcid.org/0000-0002-4698-8435"
  - family-names: Chan
    given-names: Rachel
  - family-names: Chan
    given-names: Louis
  - family-names: Alford
    given-names: James
  - family-names: Clegg
    given-names: Richard G.
    orcid: "https://orcid.org/0000-0001-7241-6679"
  - family-names: Cuadrado
    given-names: Felix
    orcid: "https://orcid.org/0000-0002-5745-1609"
  - family-names: Barnes
    given-names: Matthew Russell
  - family-names: Zhong
    given-names: Peijie
  - family-names: Pougué-Biyong
    given-names: John
    orcid: "https://orcid.org/0000-0002-6582-193X"
  - family-names: Alnaimi
    given-names: Alhamza
  date-published: 2024-03-27
  doi: 10.21105/joss.05940
  issn: 2475-9066
  issue: 95
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 5940
  title: "Raphtory: The temporal graph engine for Rust and Python"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.05940"
  volume: 9
title: "Raphtory: The temporal graph engine for Rust and Python"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

@editorialbot
Copy link
Collaborator Author

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

@editorialbot
Copy link
Collaborator Author

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited 👉 Creating pull request for 10.21105.joss.05940 joss-papers#5185
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.05940
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

@editorialbot editorialbot added accepted published Papers published in JOSS labels Mar 27, 2024
@narnolddd
Copy link

Yay, thank you @arfon and @luizirber very much! And thanks again to @arashbm and @abhishektiwari for the really helpful reviews! 🥳

@arfon
Copy link
Member

arfon commented Mar 30, 2024

@abhishektiwari, @arashbm – many thanks for your reviews here and to @luizirber for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@narnolddd – your paper is now accepted and published in JOSS ⚡🚀💥

@arfon arfon closed this as completed Mar 30, 2024
@editorialbot
Copy link
Collaborator Author

🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.05940/status.svg)](https://doi.org/10.21105/joss.05940)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.05940">
  <img src="https://joss.theoj.org/papers/10.21105/joss.05940/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.05940/status.svg
   :target: https://doi.org/10.21105/joss.05940

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Dockerfile HTML published Papers published in JOSS Python recommend-accept Papers recommended for acceptance in JOSS. review Rust Track: 5 (DSAIS) Data Science, Artificial Intelligence, and Machine Learning
Projects
None yet
Development

No branches or pull requests

6 participants