-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: BoboCEP: a Fault-Tolerant Complex Event Processing Engine for Edge Computing in Internet of Things #5858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
Review checklist for @abhishektiwariConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@r3w0p please see my initial comments. I am still working to validate software functionality. DocumentationExample usage:Authors include automated tests to validate the software functionality but no examples implementing a real-world use case. Paper describes a use case — elderly resident were to fall in their home and require an ambulance – to describe how complex event is generated and event is triggered. I think this phenomenon will make a very good example for BoboCEP. Software paperStatement of needApart from dependability, BoboCEP enables detection of complex events at edge without need of streaming raw events to the cloud. In that sense approach is privacy protecting/preserving for use cases such as smart homes which is mentioned in following section of the paper. I will suggest calling that out in statement of need. State of the fieldPaper is very light on state of the field. Paper points to a survey by Giatrakos, N.,et al and that's all. I would like authors to clearly describe how this software compares to other commonly-used frameworks in the field. Paper does not provide required context why streaming based CEP systems can't be deployed to edge/IoT devices/gateways. |
@abhishektiwari Thanks for your comments, I will work on them and get back to you ASAP. @mahsan321 It says you have generated a checklist but I am not able to see it. Alex. |
@editorialbot generate pdf |
Hello, I have made the following changes: Example UsageIn the documentation, I have introduced a new page called Use Cases which covers the Assisted Living scenario from the paper as best as I could. I could not replicate some elements of the Use Case because it is impractical (e.g., calling for an ambulance). However, I have provided working code snippets for patterns and actions. I tested the IFTTT and Twilio actions today and they both worked well. The page can be found here: https://github.com/r3w0p/bobocep/blob/joss/docs/use_cases.rst Statement of NeedIn the paper, I have discussed privacy, edge computing, etc., in more detail. See paragraph at Line 50. State of the FieldIn the paper, I have provided a more comprehensive review of existing CEP systems. See paragraph at Line 37. |
Thanks @r3w0p I will review later in the week |
Thanks for making those changes @r3w0p. New use case page looks great and provides concrete examples. @vissarion completed my review. Please let me know if anything else needed. |
Thanks @abhishektiwari ! @mahsan321 any news on your review? |
@vissarion Sorry got busy with a conference deadline. Could you assign someone else if not I will try to get it done by next week. |
Next week is fine and is much less complicated than searching for a new reviewer. Many thanks! |
Any progress updates? |
Sorry for the delay. Working on it, give me a couple of days. |
Review checklist for @mahsan321Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@mahsan321 thanks for your review. Please open issues in the repository under review to keep this thread clean of technical details.
This is fixed, right @r3w0p? |
Hi @mahsan321 and @vissarion
I have pressed all of the links in the Getting Started page that I could see and they all work for me. Which were you having trouble with specifically? I haven't changed the Getting Started page during the review process, and so the current state of the page can be found live here. If you are referring to the
This was resolved in this issue. |
@editorialbot generate pdf |
@vissarion I have made some very minor changes to the paper just now: swapped two paragraphs around, clarified some points, simplified some explanations. It is the same content nonetheless. |
Done! archive is now 10.5281/zenodo.10160409 |
@editorialbot set 1.1.1 as version |
Done! version is now 1.1.1 |
thanks @r3w0p, now I am going to to generate the final proofs, and notify the Editor in Chief. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4795, then you can now move forward with accepting the submission by compiling again with the command |
@vissarion The final proof looks good to me. Happy to move forward if you are! |
@r3w0p - I'm the track editor who will finish the processing of this submission. I've found a couple of small issues in the paper, as indicated in r3w0p/bobocep#10 - please merge this, and we can proceed to publication. |
@editorialbot recommend-accept @r3w0p - please confirm that this is ok again |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4798, then you can now move forward with accepting the submission by compiling again with the command |
@danielskatz Yes this looks okay to me 👍 |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@danielskatz @vissarion @abhishektiwari @mahsan321 Thanks for all your help in getting this work published! |
Congratulations to @r3w0p (Alexander Power) and co-authors on your publication!! And thanks to @abhishektiwari and @mahsan321 for reviewing, and to @vissarion for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @r3w0p (Alexander Power)
Repository: https://github.com/r3w0p/bobocep
Branch with paper.md (empty if default branch): joss
Version: 1.1.1
Editor: @vissarion
Reviewers: @abhishektiwari, @mahsan321
Archive: 10.5281/zenodo.10160409
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@abhishektiwari & @mahsan321, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @vissarion know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @abhishektiwari
📝 Checklist for @mahsan321
The text was updated successfully, but these errors were encountered: