-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: HNN-core: A Python software for cellular and circuit-level interpretation of human MEG/EEG #5848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
Failed to discover a |
|
Review checklist for @isdanniConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋 just checking in on how this one is going. It appears that @isdanni is nearly done with the review checklist - thanks! @neurofractal do you have a sense of your timeline for this one? |
Thanks! I just finished the initial round of review. Will follow up if I have any questions. |
Hi everyone! Just pinging this thread to see if there's anything we can do to help with the review process. |
I've sent an email ping to check in - sometimes github thread updates don't make it to folks' inboxes. |
Reviewer wrote back indicating that we should expect some updates by next week. |
Review checklist for @neurofractalConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
@editorialbot generate pdf |
@bmcfee thanks for editing here, will you check in and see how this review is progressing? |
@Kevin-Mattheus-Moerman @bmcfee apologies the hold up is on our end. We've been a bit preoccupied with conference/paper deadlines the last few weeks but have been preparing our revisions for @neurofractal's comments. The response should be ready before the end of today. |
@editorialbot generate pdf |
@editorialbot generate pdf |
@bmcfee that all sounds good! I have fixed the bulleted list formatting and added explicit figure references at The version number of the release is Lastly this is the DOI associated with the Zenodo archive: 10.5281/zenodo.10289164 And the direct web link: https://zenodo.org/records/10289164 (the title, license, and author list have been updated accordingly) Please let me know if you need anything else! |
@editorialbot set v0.3.1 as version |
Done! version is now v0.3.1 |
@editorialbot set 10.5281/zenodo.10289164 as archive |
Done! archive is now 10.5281/zenodo.10289164 |
@editorialbot generate pdf |
Thanks @ntolley ! Everything looks good on my end here. Just to confirm, since you hadn't mentioned it explicitly, have you verified the author names/affiliations and ORCID links? |
That's correct! We have confirmed with all the authors their preferred affiliations/ORCID and the records match between the JOSS paper and the Zenodo archive. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/bcm-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4821, then you can now move forward with accepting the submission by compiling again with the command |
@ntolley As AEiC I will now help to process final steps. I have checked your repository, this review, the paper, and the archive link. Most seems to be in order. I only have the below point that needs your attention:
|
Thanks @Kevin-Mattheus-Moerman for catching that! Apologies I was almost certain I had verified everyone's names. The Zenodo link should be updated with Carmen's information. Please let me know if there's anything else you need me to do. |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@ntolley congratulations on this JOSS publication! Thanks for editing @bmcfee, and a special thanks to the reviewers: @isdanni, @neurofractal ! 🥳 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks again @isdanni and @neurofractal , and congrats to @ntolley (and many coauthors)! |
Submitting author: @ntolley (Nicholas Tolley)
Repository: https://github.com/jonescompneurolab/hnn-core
Branch with paper.md (empty if default branch): joss_paper
Version: v0.3.1
Editor: @bmcfee
Reviewers: @isdanni, @neurofractal
Archive: 10.5281/zenodo.10289164
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@isdanni & @neurofractal, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @bmcfee know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @isdanni
📝 Checklist for @neurofractal
The text was updated successfully, but these errors were encountered: