Skip to content

[PRE REVIEW]: Phasik: a Python package to identify system states in partially temporal networks #5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Sep 2, 2023 · 45 comments
Assignees
Labels
Jupyter Notebook pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Sep 2, 2023

Submitting author: @maximelucas (Maxime Lucas)
Repository: https://gitlab.com/habermann_lab/phasik
Branch with paper.md (empty if default branch): joss-paper
Version: v1.3.2
Editor: @csoneson
Reviewers: @GiulioRossetti, @alexbovet
Managing EiC: George K. Thiruvathukal

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/56260df85bde3a18d82a520180eb0fe4"><img src="https://joss.theoj.org/papers/56260df85bde3a18d82a520180eb0fe4/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/56260df85bde3a18d82a520180eb0fe4/status.svg)](https://joss.theoj.org/papers/56260df85bde3a18d82a520180eb0fe4)

Author instructions

Thanks for submitting your paper to JOSS @maximelucas. Currently, there isn't a JOSS editor assigned to your paper.

@maximelucas if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Sep 2, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.85 s (247.0 files/s, 199489.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
XML                              3              2              2         104868
HTML                            65           8594            195          13636
JavaScript                      17           2438           2503           9412
Python                          37           1256           1696           4119
SVG                              4              0              0           3170
Jupyter Notebook                13              0          10868           2702
CSS                              6            202             54            822
Markdown                         6            182              0            317
reStructuredText                52            385            635            311
TeX                              1             36              0            240
YAML                             1              8              4             63
DOS Batch                        1              8              1             26
make                             1              4              7              9
TOML                             1              0              0              6
INI                              1              0              0              2
-------------------------------------------------------------------------------
SUM:                           209          13115          15965         139703
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1491

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1140/epjst/e2013-01927-7 is OK
- 10.5281/zenodo.3953119 is OK
- 10.1016/j.anbehav.2019.09.011 is OK
- 10.1016/j.physrep.2021.10.006 is OK
- 10.6084/m9.figshare.1164194 is OK
- 10.1016/j.physrep.2012.03.001 is OK
- 10.1016/0955-0674(94)90039-6 is OK
- 10.48550/arXiv.2205.08820 is OK
- 10.1037/h0057431 is OK
- 10.1209/0295-5075/121/50008 is OK
- 10.1016/j.crmeth.2023.100397 is OK
- 10.1038/s41598-018-37534-2 is OK
- 10.1145/3442442.3452052 is OK
- 10.1016/j.softx.2022.101301 is OK
- 10.5281/zenodo.3626827 is OK
- 10.1038/s41598-021-93128-5 is OK

MISSING DOIs

- 10.1126/sciadv.abj3063 may be a valid DOI for title: Flow stability for dynamic community detection
- 10.1371/journal.pone.0246961 may be a valid DOI for title: Fast and principled simulations of the SIR model on temporal networks

INVALID DOIs

- 10.1162/netn5fa5f00142 is INVALID
- https://doi.org/10.48550/arXiv.2306.16309 is INVALID because of 'https://doi.org/' prefix

@editorialbot
Copy link
Collaborator Author

@maximelucas
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1140/epjst/e2013-01927-7 is OK
- 10.1126/sciadv.abj3063 is OK
- 10.5281/zenodo.3953119 is OK
- 10.1016/j.anbehav.2019.09.011 is OK
- 10.1016/j.physrep.2021.10.006 is OK
- 10.6084/m9.figshare.1164194 is OK
- 10.1371/journal.pone.0246961 is OK
- 10.1016/j.physrep.2012.03.001 is OK
- 10.1016/0955-0674(94)90039-6 is OK
- 10.48550/arXiv.2205.08820 is OK
- 10.1037/h0057431 is OK
- 10.1209/0295-5075/121/50008 is OK
- 10.1016/j.crmeth.2023.100397 is OK
- 10.1038/s41598-018-37534-2 is OK
- 10.1145/3442442.3452052 is OK
- 10.1162/netn_a_00142 is OK
- 10.48550/arXiv.2306.16309 is OK
- 10.1016/j.softx.2022.101301 is OK
- 10.5281/zenodo.3626827 is OK
- 10.1038/s41598-021-93128-5 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@maximelucas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

@maximelucas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@maximelucas
Copy link

Hi, here are a few reviewer suggestions:

  • miratepuffin
  • Haaroon
  • ljeub-pometry
  • pholme
  • GiulioRossetti

Also, I've now released v1.3.3 that fixes a test bug from the previous version.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@csoneson
Copy link
Member

csoneson commented Sep 4, 2023

@editorialbot assign @csoneson as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @csoneson is now the editor

@csoneson
Copy link
Member

csoneson commented Sep 4, 2023

👋🏻 @maximelucas - I will be the editor for your submission, and will start by recruiting at least two reviewers (thanks for the suggestions!)

@csoneson
Copy link
Member

csoneson commented Sep 4, 2023

👋🏻 @miratepuffin, @pholme, @GiulioRossetti - would you be interested in reviewing this submission for the Journal of Open Source Software (JOSS)?

Phasik: a Python package to identify system states in partially temporal networks
(#5799)

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

@GiulioRossetti
Copy link

@csoneson Hi!

Sure, I'm happy to contribute. Do we have an expected deadline to meet for the review?

@csoneson
Copy link
Member

csoneson commented Sep 4, 2023

@GiulioRossetti Brilliant, thanks!
Typically we ask reviewers to aim to provide an initial assessment within approximately 2 weeks after opening the review issue (which will happen once all reviewers have been assigned). However, in many cases it turns out to be easier to provide comments successively as one goes through the submission, rather than everything at once.

@GiulioRossetti
Copy link

That's perfect.
So, the review can be seen as a discussion focused on the key points listed in the page you shared (if I get it right). I assume all comments will be made in this thread, right?

@csoneson
Copy link
Member

csoneson commented Sep 4, 2023

So, the review can be seen as a discussion focused on the key points listed in the page you shared (if I get it right).

Yes, exactly.

I assume all comments will be made in this thread, right?

Almost 🙂 As soon as I have secured one more reviewer, I will close this issue and we will move to the actual review issue. Once there, you will be able to generate a new post with your own review checklist (which will contain these points: https://joss.readthedocs.io/en/latest/review_checklist.html). The goal is then to work with the authors to help them meet these criteria. Reviewers are encouraged to open issues directly in the software repository, or to keep the discussion in the review issue if that seems more suitable.

So for now, you are of course very welcome to start looking at the submission, but to keep things simple and everything in one place, I would ask that you'd wait to provide your comments until both reviewers are secured and the actual review issue is opened.

Thanks, and don't hesitate to let me know if you have other questions!

@maximelucas
Copy link

Hi! Thank you @csoneson for editing this and @GiulioRossetti for agreeing to review.

@csoneson
Copy link
Member

csoneson commented Sep 7, 2023

👋🏻 @Haaroon, @ljeub-pometry - would one of you be willing to review this submission for the Journal of Open Source Software?

Phasik: a Python package to identify system states in partially temporal networks
(#5799)

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

@csoneson
Copy link
Member

👋🏻 @benmaier - would you be willing to review this submission for the Journal of Open Source Software?

Phasik: a Python package to identify system states in partially temporal networks
(#5799)

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

@csoneson
Copy link
Member

👋🏻 @Viech - would you be interested in reviewing this submission for JOSS?

Phasik: a Python package to identify system states in partially temporal networks
(#5799)

@benmaier
Copy link

Hi @csoneson and @maximelucas ! Looks super interesting, but unfortunately I won't have the time to work on this as I'm currently transitioning out of academia. Apologies

@csoneson
Copy link
Member

@benmaier Thanks for your response! If you can think of a suitable colleague who might be interested in reviewing, please feel free to let us know!

@maximelucas
Copy link

If needed, more potential reviewers:

  • naokimas
  • alexbovet
  • wiheto

@mjstahlberg
Copy link

mjstahlberg commented Sep 15, 2023

I would be available time-wise but I do not see a large enough intersection with my topic areas to feel comfortable reviewing.

@csoneson
Copy link
Member

👋🏻 @naokimas, @alexbovet, @wiheto - would one of you be willing to review this submission for the Journal of Open Source Software?

Phasik: a Python package to identify system states in partially temporal networks
(#5799)

JOSS is a free, open-source, community-driven and developer-friendly online journal. The review process is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged.

JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See https://joss.readthedocs.io/en/latest/review_criteria.html.

Thanks in advance!

@maximelucas
Copy link

I found some more on your list of reviewers that might be more active on Github:

  • paulbrodersen
  • dhimmel
  • szhorvat
  • dinacmistry

@wiheto
Copy link

wiheto commented Sep 21, 2023

Hey, thanks for inviting me and it’s something I definitely want to check out someday. I’m currently swamped with other commitments which means I am unable to give a sufficient review in a reasonable time period.

@alexbovet
Copy link

Hey, thanks for inviting me as well. What would be the deadline? I am also currently swamped...

@csoneson
Copy link
Member

@alexbovet - usually we ask reviewers to give an initial assessment within 2-3 weeks. However, in many cases it turns out to be easier to provide comments successively as one goes through the submission and the checklist, rather than everything at once.

@csoneson
Copy link
Member

👋🏻 @alexbovet - could you let us know if you would be willing to take on the review given the additional information above? Thanks!

@maximelucas
Copy link

No worries @wiheto. Thanks for considering it @alexbovet! If it helps deciding, the review is check-list driven, and you can see an example of the check-list here.

@alexbovet
Copy link

Yes, I'll do it. thanks

@csoneson
Copy link
Member

Awesome, thanks @alexbovet! I'll assign both reviewers and start the review issue.

@csoneson
Copy link
Member

@editorialbot add @GiulioRossetti as reviewer

@editorialbot
Copy link
Collaborator Author

@GiulioRossetti added to the reviewers list!

@csoneson
Copy link
Member

@editorialbot add @alexbovet as reviewer

@editorialbot
Copy link
Collaborator Author

@alexbovet added to the reviewers list!

@csoneson
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5872.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jupyter Notebook pre-review Python TeX Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Development

No branches or pull requests

9 participants