Skip to content

[PRE REVIEW]: Pyafscgap.org: Open source multi-modal Python-based tools for NOAA AFSC RACE GAP #5516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
editorialbot opened this issue Jun 2, 2023 · 47 comments
Closed

[PRE REVIEW]: Pyafscgap.org: Open source multi-modal Python-based tools for NOAA AFSC RACE GAP #5516

editorialbot opened this issue Jun 2, 2023 · 47 comments
Assignees
@Kevin-Mattheus-Moerman
Labels
Dockerfile pre-review pyOpenSci Submissions associated with pyOpenSci Python Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 2, 2023 •
edited
Loading

Submitting author: @sampottinger (A Samuel Pottinger)
Repository: https://github.com/SchmidtDSE/afscgap
Branch with paper.md (empty if default branch):
Version: v1.0.2
Editor: @Kevin-Mattheus-Moerman
Reviewers: @Kevin-Mattheus-Moerman
Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76"><img src="https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76/status.svg)](https://joss.theoj.org/papers/2b48c80992a67325863aa2fa9b51ae76)

Author instructions

Thanks for submitting your paper to JOSS @sampottinger. Currently, there isn't a JOSS editor assigned to your paper.

@sampottinger if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials labels Jun 2, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.13 s (766.0 files/s, 174710.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             9              0              0           6657
Python                          29           1524           2993           3447
JavaScript                      14            535           1010           2327
Markdown                        16            365              0            997
CSS                              2            103              0            443
HTML                             6             16              0            392
SQL                             10              5              0            324
Jupyter Notebook                 1              0            894            191
TeX                              1             22              0            189
YAML                             4              8              2            160
SVG                              1              0              1             54
TOML                             1              5              0             54
Bourne Shell                     5              9              8             29
Dockerfile                       1              9              8             28
-------------------------------------------------------------------------------
SUM:                           100           2601           4916          15292
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1035

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1023/a:1016528631593 is OK

MISSING DOIs

- 10.1007/978-1-4842-6011-1_12 may be a valid DOI for title: Oracle Rest Data Services

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@sampottinger
Copy link

sampottinger commented Jun 2, 2023 •
edited
Loading

Hello! Excited about this and thanks for taking us to this step. Please note that pyopensci had one more thing for us to change in our badges and the current version is 1.0.2. Thanks!

See pyOpenSci/software-submission#93

We are approved by pyopensci and listed on their website.

@sampottinger
Copy link

@editorialbot set v1.0.2 as version

@editorialbot
Copy link
Collaborator Author

I'm sorry @sampottinger, I'm afraid I can't do that. That's something only editors are allowed to do.

@sampottinger
Copy link

sampottinger commented Jun 4, 2023 •
edited
Loading

Oh ok 😅. Sorry I might need someone's help with updating that version. In the meantime, I'll take care of that DOI. I also read some recent JOSS reviews here so will try to take care of a few small things I've seen highlighted elsewhere.

sampottinger added a commit to SchmidtDSE/afscgap that referenced this issue Jun 4, 2023
@sampottinger
Response to recent JOSS reviews.
8d9460f 
Try to shorten paper to meet length criteria, clarify that it is multiple survey programs / multiple datasets behind a common API, check ORDS DOI (there doesn't appear to be an appropriate one).

See openjournals/joss-reviews#5516
@sampottinger sampottinger mentioned this issue Jun 4, 2023
Merged
@sampottinger
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@sampottinger
Copy link

sampottinger commented Jun 4, 2023 •
edited
Loading

Regenerated the preview! Also wanted to mention the json line count… that json line count comes from the npm related files. Thanks!

@sampottinger
Copy link

The ORDS DOI from editorial bot (10.1007/978-1-4842-6011-1_12) was not right. I think the citation as is might still be best. Thanks!

@sampottinger
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.24 s (418.0 files/s, 95343.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             9              0              0           6657
Python                          29           1524           2993           3447
JavaScript                      14            535           1010           2327
Markdown                        16            365              0            997
CSS                              2            103              0            443
HTML                             6             16              0            392
SQL                             10              5              0            324
Jupyter Notebook                 1              0            894            191
TeX                              1             22              0            189
YAML                             4              8              2            160
SVG                              1              0              1             54
TOML                             1              5              0             54
Bourne Shell                     5              9              8             29
Dockerfile                       1              9              8             28
-------------------------------------------------------------------------------
SUM:                           100           2601           4916          15292
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1051

@sampottinger sampottinger mentioned this issue Jun 5, 2023
Merged
@sampottinger
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.11 s (903.8 files/s, 206142.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             9              0              0           6657
Python                          29           1524           2993           3447
JavaScript                      14            535           1010           2327
Markdown                        16            365              0            997
CSS                              2            103              0            443
HTML                             6             16              0            392
SQL                             10              5              0            324
Jupyter Notebook                 1              0            894            191
TeX                              1             22              0            189
YAML                             4              8              2            160
SVG                              1              0              1             54
TOML                             1              5              0             54
Bourne Shell                     5              9              8             29
Dockerfile                       1              9              8             28
-------------------------------------------------------------------------------
SUM:                           100           2601           4916          15292
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1007

@sampottinger
Copy link

Sorry for the noise. I saw we were getting a little above the length guideline. Just trimmed a little bit to get closer to the guidance. Thanks again for your consideration.

@sampottinger
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot set v1.0.2 as version

@editorialbot
Copy link
Collaborator Author

Done! version is now v1.0.2

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot check references

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1023/a:1016528631593 is OK

MISSING DOIs

- 10.1007/978-1-4842-6011-1_12 may be a valid DOI for title: Oracle Rest Data Services

INVALID DOIs

- None

@Kevin-Mattheus-Moerman
Copy link
Member

@sampottinger I am the AEiC for this track and here to help process initial steps. In the meantime, can you please see if you can address that potentially missing DOI ☝️ ? You can edit your .bib file and call @editorialbot check references here to check them again.

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @graciellehigino as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@sampottinger
Copy link

Hello! Thanks very much @Kevin-Mattheus-Moerman and nice to meet you @graciellehigino.

can you please see if you can address that potentially missing DOI

Appreciate your flagging this. The paper is citing ORDS itself and the DOI offered is a book about getting started with ORDS. The technology itself does not appear to have a publication with a DOI. Thank you!

here to help process initial steps

We appreciate your help. I just briefly wanted to mention that I noticed that some other submissions have a pyopensci tag but we do not. That in mind, I just wanted to note that pyopensci has accepted / approved us. See pyOpenSci/software-submission#93.

Thank you both! Please let me know if there’s anything else I can do.

@Kevin-Mattheus-Moerman
Copy link
Member

@graciellehigino 👋 do you think you can help edit this one?

@sampottinger
Copy link

Hello all! Just checking in. Is there anything we can do to help from our end? Thanks for your time!

@graciellehigino
Copy link

Hi all! This seems like a really interesting submission! However, I don't think I can help with this one because I always have a hard time finding Python users among ecologists. I think I'm on the wrong network for this... Sorry!

@sampottinger
Copy link

Thanks @graciellehigino! @Kevin-Mattheus-Moerman how would you like to proceed? Thank you both!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot invite @Bisaloo as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@Bisaloo Bisaloo added the pyOpenSci Submissions associated with pyOpenSci label Jun 26, 2023
@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @Kevin-Mattheus-Moerman is now the editor

@Kevin-Mattheus-Moerman
Copy link
Member

This is a pyopensci related submission which was reviewed here: pyOpenSci/software-submission#93

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

Can't start a review without reviewers

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot assign me as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot add @Kevin-Mattheus-Moerman as reviewer

@editorialbot
Copy link
Collaborator Author

@Kevin-Mattheus-Moerman added to the reviewers list!

@Kevin-Mattheus-Moerman
Copy link
Member

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman

Labels
Dockerfile pre-review pyOpenSci Submissions associated with pyOpenSci Python Shell Track: 2 (BCM) Biomedical Engineering, Biosciences, Chemistry, and Materials
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sampottinger @Kevin-Mattheus-Moerman @Bisaloo @graciellehigino @editorialbot