Skip to content

[PRE REVIEW]: PYDAQ: Data Acquisition and Experimental Analysis with Python #5355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
editorialbot opened this issue Apr 12, 2023 · 36 comments
Closed

[PRE REVIEW]: PYDAQ: Data Acquisition and Experimental Analysis with Python #5355

editorialbot opened this issue Apr 12, 2023 · 36 comments
Assignees
@pibion @galessiorob @nataliakeles
Labels
C++ pre-review Python TeX Track: 3 (PE) Physics and Engineering

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Apr 12, 2023 •
edited
Loading

Submitting author: @samirmartins (Samir Martins)
Repository: https://github.com/samirmartins/pydaq
Branch with paper.md (empty if default branch):
Version: v0.0.3
Editor: @pibion
Reviewers: @galessiorob, @nataliakeles
Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e21c95f47ea3dc510e87406f566591ee"><img src="https://joss.theoj.org/papers/e21c95f47ea3dc510e87406f566591ee/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e21c95f47ea3dc510e87406f566591ee/status.svg)](https://joss.theoj.org/papers/e21c95f47ea3dc510e87406f566591ee)

Author instructions

Thanks for submitting your paper to JOSS @samirmartins. Currently, there isn't a JOSS editor assigned to your paper.

@samirmartins if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 3 (PE) Physics and Engineering labels Apr 12, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author 

Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (670.1 files/s, 80164.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           5            390            334           1036
Markdown                        11            278              0            677
Jupyter Notebook                12              0           1236            194
TeX                              1             11              0            107
YAML                             2              5              4             57
TOML                             1              7              0             37
Arduino Sketch                   1             10             13             26
SVG                              4              0              0              4
-------------------------------------------------------------------------------
SUM:                            37            701           1587           2138
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1220

@editorialbot
Copy link
Collaborator Author

Failed to discover a Statement of need section in paper

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.02384 is OK
- 10.1088/1361-6404/aae35c is OK
- 10.1109/EIConRus49466.2020.9038964 is OK
- 10.1109/IICSPI48186.2019.9096044 is OK
- 10.1109/TIM.2019.2914711 is OK

MISSING DOIs

- 10.1016/0005-1098(89)90019-8 may be a valid DOI for title: System identification: theory for the user
- 10.1109/access.2019.2926057 may be a valid DOI for title: Control of Hysteretic Systems Through an Analytical Inverse Compensation Based on a NARX Model
- 10.1016/j.ymssp.2015.12.031 may be a valid DOI for title: Sufficient conditions for rate-independent hysteresis in autoregressive identified models

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@kyleniemeyer
Copy link

Hi @samirmartins, can you please check on those missing DOI warnings? Also, your paper is missing the required "Statement of Need" section.

@kyleniemeyer
Copy link

@editorialbot invite @pibion as editor

Hi @pibion, can you edit this?

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@samirmartins
Copy link

Dear @kyleniemeyer ,

thank you for your message. You can see below answers about issues raised by you:

  • "Statement of Need" section was included now.
  • Missing DOI warnings were corrected.

Let me know if you have further questions.

Best regards,

Samir

@kyleniemeyer
Copy link

@editorialbot check references

@editorialbot
Copy link
Collaborator Author 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.02384 is OK
- 10.1016/0005-1098(89)90019-8 is OK
- 10.1002/9781118535561 is OK
- 10.1088/1361-6404/aae35c is OK
- 10.1109/EIConRus49466.2020.9038964 is OK
- 10.1016/j.softx.2020.100495 is OK
- 10.1109/access.2019.2926057 is OK
- 10.1016/j.ymssp.2015.12.031 is OK
- 10.1109/IICSPI48186.2019.9096044 is OK
- 10.1109/TIM.2019.2914711 is OK
- 10.48550/arXiv.1201.0490 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@kyleniemeyer
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@pibion
Copy link

pibion commented May 8, 2023

Hi @kyleniemeyer, I can edit this, apologies for the delayed response.

@kyleniemeyer
Copy link

@pibion great, thank you

@kyleniemeyer
Copy link

@editorialbot assign @pibion as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @pibion is now the editor

@pibion
Copy link

pibion commented May 22, 2023

@samirmartins apologies for the delay getting started here! I'm currently working to identify reviewers; do you have anyone in mind who might be able to review your submission?

@samirmartins
Copy link

Dear @pibion,

I currently do not have anyone in mind to appoint as a potential reviewer.

Let me know if I can help in anything else.

@samirmartins
Copy link

Dear @pibion and @kyleniemeyer,

I hope this message finds you well. It has been two months since the article submission, and it has not yet been assigned to reviewers. Is there any estimate on when this will happen? Is there anything I can do to help initiate the review process?

Best regards,

Samir

@pibion
Copy link

pibion commented Jun 6, 2023

@samirmartins apologies for the delay - it's been hard to find reviewers. I'm hoping I'll have more luck now that the semester is over for most people!

The most helpful thing are suggestions for where I might find appropriate reviewers or suggestions for reviewers. Thanks in advance!

@samirmartins
Copy link

Dear @pibion, thank you for your response. All the reviewers I can recommend have some connection with me (either professionally or personally). If it's possible to suggest these individuals for the review, let me know, and I will tag them in this conversation.

One suggestion is to consider inviting authors of previous articles in JOSS. They might be able to assist with the review.

Kind regards,

Samir Martins

@samirmartins
Copy link

Dear @pibion,

I'd like to suggest @nataliakeles as a potential reviewer. Please let me know if you need any additional suggestions for reviewers.

Best regards,

Samir

@samirmartins
Copy link

samirmartins commented Jul 10, 2023 •
edited
Loading

Dear @pibion ,

Additionally, I would like to suggest @galessiorob as a reviewer. I have contacted both of them (@galessiorob and @nataliakeles) via email, and they are available to conduct the review if it is the editor's wish.

Looking forward to further information.

Best regards,

Samir

@pibion
Copy link

pibion commented Jul 11, 2023

@samirmartins thank you for the suggestions, and apologies for the delayed response!

@pibion
Copy link

pibion commented Jul 11, 2023

@nataliakeles, @galessiorob, would you be able to review this submission for JOSS? The review consists of checking off items that are in a "good" state, and requesting that the repository author improve anything that doesn't yet meet the checklist criteria.

@nataliakeles
Copy link

nataliakeles commented Jul 11, 2023 via email

@galessiorob
Copy link

Happy to act as a reviewer 👍

@samirmartins
Copy link

Thank you all. I am completely available for any necessary correction.

Best regards,

Samir

@pibion
Copy link

pibion commented Jul 18, 2023

@editorialbot add @galessiorob as reviewer

@editorialbot
Copy link
Collaborator Author

@galessiorob added to the reviewers list!

@pibion
Copy link

pibion commented Jul 18, 2023

@editorialbot add @nataliakeles as reviewer

@editorialbot
Copy link
Collaborator Author

@nataliakeles added to the reviewers list!

@pibion
Copy link

pibion commented Jul 18, 2023

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5662.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pibion pibion

@galessiorob galessiorob

@nataliakeles nataliakeles

Labels
C++ pre-review Python TeX Track: 3 (PE) Physics and Engineering
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kyleniemeyer @pibion @galessiorob @samirmartins @nataliakeles @editorialbot