-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: jsPsych: Enabling an Open-Source Collaborative Ecosystem of Behavioral Experiments #5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋 @jodeleeuw, this is where the review will actually take place. @pmcharrison, @xinyiguan, @chartgerink please use this issue to leave your comments and feedback for the authors (and please read all the instructions above) — however:
Hope this is clear, let me know if not, and thank you for your time! |
Review checklist for @xinyiguanConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Tagging my coauthors here for ease of access: @becky-gilbert @bjoluc |
Review checklist for @chartgerinkConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jodeleeuw oh, nice idea. Thank you! |
Review checklist for @pmcharrisonConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jodeleeuw looking good! great that jsPsych version 7 will be credited in this way! Regarding 'state of the field', I wonder if you can add a touch more here. This is the main comparison with previous work:
This is a positive statement about what jsPsych does in terms of plugins, but maybe you can spare a few words to say whether/which other programs have analogous constructs to plugins? Regarding the references, I just noticed that some of the capitalisation hasn't come through (e.g. r package, pushkin). |
@editorialbot generate pdf |
Thank you @pmcharrison! I've fixed the reference formatting issues. We definitely want to correctly characterize the state of field. I think one issue is getting clear about what we think the distinction is between plugins and other ways of abstracting experiment design.
Does that seem reasonable to you? If so, I'll work on a more concise description for the paper. If not, I'm happy to get feedback! |
Hi @jodeleeuw, many thanks for this interesting overview! It's very helpful to see it laid out in this way. From you say, I think I agree that the best thing is to emphasise the 'community library' aspect of this. The software mentioned in the first category does contain analogous constructions to plugins under the hood, but it's not so easy to contribute your own unless you're a core developer. You're right that psychTestR in theory allows such contributions, but in practice the vast majority of psychTestR community contributions correspond to entire tests (e.g. a particular IQ test, a particular questionnaire) rather than new response interfaces. In contrast, the jsPsych community library provides an unparalleled source of interfaces. Maybe all that's needed is something like 'While many psychology experiment frameworks contain abstractions analogous to plugins, it is typically hard or impossible for users to contribute their own plugins. In contrast, we have worked hard to develop a system for jsPsych that makes it easy for users to develop their own plugins and share them with other psychologists via open-source repositories. Our community library already contains X plugins, ranging from Y to Z, which ....' What do you think? |
@pmcharrison thank you for the very helpful suggestion. We borrowed chunks of it and reworked the statement of need section a bit. Here's the commit so you can see exactly what changed, though I guess it is all one big line in markdown so the actual changes aren't nicely highlighted. |
@editorialbot generate pdf |
@jodeleeuw I love it, great job! @oliviaguest I'm happy, checklist complete! |
@pmcharrison thank you for the review! |
@jodeleeuw Thank you for this very cool development! I think jsPsych is a valuable contribution to the community, and I particularly appreciate the community-driven and self-contained modular design aspects of the software. The latest version, incorporating feedback from @pmcharrison, looks excellent and has already addressed the points I wanted to raise in my previous review draft. @oliviaguest I have completed my checklist! |
@editorialbot generate pdf |
Looks like it didn't generate for some reason after your last message, so I'll try again. |
Everything looks good to me. Thanks @oliviaguest for editing, and @pmcharrison, @xinyiguan, @chartgerink for the time taken to review! |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot check references |
|
@jodeleeuw can you make the title of the zenodo archive the same as the paper? And we're done! 🥳 |
All set! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#4218, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats! @jodeleeuw |
Sorry for going AWOL, I had a super ad migraine. Big thank you to the reviewers @pmcharrison, @xinyiguan, @chartgerink! And congratulations @jodeleeuw! 🥳 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @jodeleeuw (Joshua de Leeuw)
Repository: https://github.com/jspsych/jspsych
Branch with paper.md (empty if default branch): joss-paper
Version: v7.3.2
Editor: @oliviaguest
Reviewers: @pmcharrison, @xinyiguan, @chartgerink
Archive: 10.5281/zenodo.7702307
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@pmcharrison & @xinyiguan & @chartgerink, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @oliviaguest know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @xinyiguan
📝 Checklist for @chartgerink
📝 Checklist for @pmcharrison
The text was updated successfully, but these errors were encountered: