Skip to content

[PRE REVIEW]: XGI: A Python package for higher-order interaction networks #5125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Feb 3, 2023 · 71 comments
Closed
Assignees
Labels
Jupyter Notebook pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Feb 3, 2023

Submitting author: @nwlandry (Nicholas Landry)
Repository: https://github.com/ComplexGroupInteractions/xgi
Branch with paper.md (empty if default branch): paper
Version: v0.5.4
Editor: @vissarion
Reviewers: @arashbm, @MridulS, @tbsexton
Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a7863c834c0d9cd78031b4ad502446eb"><img src="https://joss.theoj.org/papers/a7863c834c0d9cd78031b4ad502446eb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a7863c834c0d9cd78031b4ad502446eb/status.svg)](https://joss.theoj.org/papers/a7863c834c0d9cd78031b4ad502446eb)

Author instructions

Thanks for submitting your paper to JOSS @nwlandry. Currently, there isn't a JOSS editor assigned to your paper.

@nwlandry if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Feb 3, 2023
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.20 s (726.3 files/s, 172411.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             3              1              0           9920
Python                          64           2929           5117           7480
Jupyter Notebook                12              0           4851            869
Markdown                         8            257              0            650
TeX                              1             30              0            314
reStructuredText                50            375            563            303
DOS Batch                        1             34              2            227
SVG                              1              1              1            173
make                             1             33              8            159
YAML                             2             16             16             81
INI                              1              0              0              7
CSS                              1              0              0              5
-------------------------------------------------------------------------------
SUM:                           145           3676          10558          20188
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 2492

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.2208.00909 is OK
- 10.1093/comnet/cnx001 is OK
- 10.1038/s42005-022-00963-7 is OK
- 10.1016/j.softx.2022.101301 is OK
- 10.1007/s41109-022-00514-7 is OK
- 10.1016/j.physrep.2020.05.004 is OK
- 10.1137/18M1203031 is OK
- 10.1093/comnet/cnaa018 is OK
- 10.1007/978-3-319-49787-7_12 is OK
- 10.1093/bioinformatics/btac347 is OK
- 10.1145/3458723 is OK
- 10.1137/21M1399427 is OK
- 10.1038/s41467-019-10431-6 is OK
- 10.1016/j.disc.2008.02.037 is OK
- 10.1063/5.0020034 is OK
- 10.1103/PhysRevE.90.012805 is OK
- 10.1103/PhysRevResearch.2.033410 is OK
- 10.1103/PhysRevLett.124.218301 is OK
- 10.1103/PhysRevE.101.032310 is OK
- 10.6084/m9.figshare.1164194 is OK
- 10.1103/PhysRevLett.122.248301 is OK
- 10.24166/im.01.2020 is OK
- 10.48550/arXiv.2203.03060 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@danielskatz
Copy link

@nwlandry - thanks for your submission. I see that your paper is ~2500 words, which far beyond the JOSS suggestion of ~1000. Please take a look at the JOSS example paper for what a JOSS paper should contain, and remove some of your current content (eg the API description). Perhaps some parts can be put in the repo and pointed at, or in the documentation?

Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to generate a new PDF and the command @editorialbot check repository to do a number of checks, including the length of the paper in words. editorialbot commands need to be the first entry in a new comment.

Once this is done, please let me know, and I'll then work on finding an editor for this submission.

@nwlandry
Copy link

nwlandry commented Feb 3, 2023

Hi @danielskatz - thank you for the feedback and sorry about that! That sounds good to me!

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.33 s (438.8 files/s, 103924.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             3              1              0           9920
Python                          64           2929           5117           7480
Jupyter Notebook                12              0           4851            869
Markdown                         8            239              0            589
TeX                              1             30              0            314
reStructuredText                50            375            563            303
DOS Batch                        1             34              2            227
SVG                              1              1              1            173
make                             1             33              8            159
YAML                             2             16             16             81
INI                              1              0              0              7
CSS                              1              0              0              5
-------------------------------------------------------------------------------
SUM:                           145           3658          10558          20127
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1354

@nwlandry
Copy link

nwlandry commented Feb 6, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@maximelucas
Copy link

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@nwlandry
Copy link

nwlandry commented Feb 7, 2023

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.55 s (262.2 files/s, 62064.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             3              1              0           9920
Python                          64           2929           5117           7480
Jupyter Notebook                12              0           4851            869
Markdown                         8            233              0            579
TeX                              1             30              0            314
reStructuredText                50            375            563            303
DOS Batch                        1             34              2            227
SVG                              1              1              1            173
make                             1             33              8            159
YAML                             2             16             16             81
INI                              1              0              0              7
CSS                              1              0              0              5
-------------------------------------------------------------------------------
SUM:                           145           3652          10558          20117
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1073

@nwlandry
Copy link

nwlandry commented Feb 7, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@maximelucas
Copy link

@editorialbot generate pdf

@maximelucas
Copy link

@editorialbot check repository

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.87 s (166.5 files/s, 39406.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JSON                             3              1              0           9920
Python                          64           2929           5117           7480
Jupyter Notebook                12              0           4851            869
Markdown                         8            232              0            578
TeX                              1             30              0            314
reStructuredText                50            375            563            303
DOS Batch                        1             34              2            227
SVG                              1              1              1            173
make                             1             33              8            159
YAML                             2             16             16             81
INI                              1              0              0              7
CSS                              1              0              0              5
-------------------------------------------------------------------------------
SUM:                           145           3651          10558          20116
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1043

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@maximelucas
Copy link

@editorialbot check repository

@nwlandry
Copy link

nwlandry commented Feb 8, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

📄 Preprint file created: Find it here in the Artifacts list 📄

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@vissarion
Copy link

Can you add something in the intro that defines/explains higher-order networks? Otherwise, this looks good, and I can start processing the submission while you do this.

I added a brief description of higher-order networks in the introduction - happy to add a more detailed explanation if that is better.

It looks good to me, thanks!

Since I am not an expert in high-order networks, I found the following two introductory references very useful:

@maximelucas
Copy link

Great!

These are good references indeed. Another one, open access and by some authors of this manuscript:

@vissarion
Copy link

👋 @tbsexton, @jGaboardi, @jonjoncardoso, @zoometh, @akbaritabar would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@akbaritabar
Copy link

👋 @tbsexton, @jGaboardi, @jonjoncardoso, @zoometh, @akbaritabar would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

I am currently unavailable (for the next couple of months), I am sorry.

@sudarshansudarshan
Copy link

sudarshansudarshan commented Feb 13, 2023 via email

@jGaboardi
Copy link

@vissarion, I currently do not have the bandwidth to give a proper review. Sorry, and please keep me in mind for future reviews.

@zoometh
Copy link

zoometh commented Feb 15, 2023

@vissarion currently I'm overwhelmed with work and classes, I have to decline, sorry

@jonjoncardoso
Copy link

jonjoncardoso commented Feb 15, 2023 via email

@nwlandry
Copy link

Some potential reviewers (if it's helpful): dschult, MridulS, jarrodmillman, rossbar, count0, arashbm.

@vissarion
Copy link

👋 @dschult, @MridulS, @jarrodmillman, @rossbar, @count0, @arashbm would any of you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

@arashbm
Copy link

arashbm commented Feb 16, 2023

I'd be happy to review this submission.

@vissarion
Copy link

@editorialbot add @arashbm as reviewer

@editorialbot
Copy link
Collaborator Author

@arashbm added to the reviewers list!

@vissarion
Copy link

Thanks @arashbm ! I am waiting for one more reviewer now to start the review process.

@MridulS
Copy link

MridulS commented Feb 16, 2023

I can help review this submission too :)

@rtbs-dev
Copy link

Hi there, I'd definitely be interested, this looks right up my alley. Thanks!

@vissarion
Copy link

@editorialbot add @MridulS as reviewer

@editorialbot
Copy link
Collaborator Author

@MridulS added to the reviewers list!

@vissarion
Copy link

@editorialbot add @tbsexton as reviewer

@editorialbot
Copy link
Collaborator Author

@tbsexton added to the reviewers list!

@vissarion
Copy link

Thanks to all of you, I will start now the review process with 3 reviewers.

@vissarion
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #5162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jupyter Notebook pre-review Python TeX Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Development

No branches or pull requests