-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: signnet: An R package for analyzing signed networks #4987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Review checklist for @cosimameyerConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
👋🏼 @schochastics @cosimameyer @zpneal this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering @editorialbot generate my checklist as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention #4987 so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package. We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@sbenthall) if you have any questions/concerns. |
Review checklist for @zpnealConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
This is a much-needed package and very clear description of its features. I only have a few minor suggestions: Installation - The package installs fine (I am reviewing the development version from GitHub). However, I suggest including the installation syntax directly in the manuscript. For example, maybe insert Reproducibility & Functionality - State of the field - You cite the R References - |
added. Good that you bring this up: The CRAN version is outdated at the moment but after this review process I am going to submit the new version again. So the version to be reviewed is on Github but eventually it will be on CRAN so I added
Happy to discuss this point, but I would like to keep it under Suggests. The ompr ecosystem includes several packages which I do not want to force onto every user. Of course the exact calculation is important, but I'd rather have those who want to use it go the extra mile given their might be quirks in the installation. I did add a sentence now explaining that more packages are needed to use the function. But as I said, I can still be convinced otherwise :)
I think I went on auto pilot here. "NP hard-> small networks". Apologies for that. I did implement the efficient algorithm but the solver is not as efficient as the one used bei Samin, I believe. I did add a reference and also changed the sentence.
good point! I added a sentence at the end of the Statement of need
changed |
@editorialbot generate pdf |
Thanks for these revisions. (FYI - There's an extra quotation mark in the new line to install signnet) Re: ompr - I agree about keeping required dependencies to a minimum. I think keeping this as suggests rather than imports makes sense, but this means the code in the paper won't replicate without some extra user steps. I suggest adding to the paper the extra With that change, I can also tick off the "reproducibility" item from the checklist and would be satisfied with the submission. |
Thats of course a good point. I fixed the extra quotation and also now added the installation step. |
@editorialbot generate pdf |
Looks great! I've checked every item on the checklist and support publication of this paper. @sbenthall Is there anything else I need to do to mark my review as complete? |
That was a very fast review, Zachary :) I’ll do my best to finish mine also as fast as possible. Just a quick note, as mentioned in the other issue, I‘m currently on holiday and will only get a chance to look into the package at the end of next week - but I‘m looking forward to digging into it! It looks very cool! 😊 |
@editorialbot set v1.0.0 as version |
Done! version is now v1.0.0 |
I recommend this submission for acceptance! |
@editorialbot recommend-accept |
|
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3866, then you can now move forward with accepting the submission by compiling again with the command |
@sbenthall Just to double check: Is there anything needed from me to finalize the process? Thanks |
@schochastics You are all set, I believe. We are waiting for the editors to do the final sign off. |
ah perfect thanks |
@editorialbot check references |
@editorialbot recommend-accept |
|
|
1 similar comment
|
@editorialbot accept |
|
👋 @openjournals/sbcs-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3905, then you can now move forward with accepting the submission by compiling again with the command |
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@schochastics and @sbenthall, sorry for being delayed, I am ill. Congratulations! 🥳 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @schochastics (David Schoch)
Repository: https://github.com/schochastics/signnet
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @sbenthall
Reviewers: @cosimameyer, @zpneal
Archive: https://doi.org/10.5281/zenodo.7522563
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@cosimameyer & @zpneal, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sbenthall know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @cosimameyer
📝 Checklist for @zpneal
The text was updated successfully, but these errors were encountered: