Skip to content

[PRE REVIEW]: Pyripherals: A Python Package for Communicating with Peripheral Electronic Devices #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
editorialbot opened this issue Jul 18, 2022 · 40 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 18, 2022

Submitting author: @Ajstros (Abraham Stroschein)
Repository: https://github.com/Ajstros/pyripherals
Branch with paper.md (empty if default branch):
Version: v0.0.2
Editor: @danielskatz
Reviewers: @untzag, @askuric
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/35fd570e4d8132210476bbaf747ca5d7"><img src="https://joss.theoj.org/papers/35fd570e4d8132210476bbaf747ca5d7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/35fd570e4d8132210476bbaf747ca5d7/status.svg)](https://joss.theoj.org/papers/35fd570e4d8132210476bbaf747ca5d7)

Author instructions

Thanks for submitting your paper to JOSS @Ajstros. Currently, there isn't a JOSS editor assigned to your paper.

@Ajstros if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=0.14 s (656.5 files/s, 225174.5 lines/s)
-----------------------------------------------------------------------------------
Language                         files          blank        comment           code
-----------------------------------------------------------------------------------
JavaScript                          14           2405           2473           9223
HTML                                22           2952             66           6383
Python                              27            982           1588           2849
TeX                                  2             63             14            297
Coq                                  1             40              0            257
reStructuredText                    10            207             88            233
Markdown                             7             80              0            202
YAML                                 2              6             18             31
DOS Batch                            1              8              1             26
TOML                                 1              1              0              9
make                                 1              4              7              9
Verilog-SystemVerilog                1              0              0              4
-----------------------------------------------------------------------------------
SUM:                                89           6748           4255          19523
-----------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1140

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1145/2851581.2890266 may be a valid DOI for title: FrontPanel®

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Ajstros
Copy link

Ajstros commented Jul 18, 2022

Suggested Potential Reviewers:

  • ixjlyons
  • sptennak
  • chekoduadarsh
  • sneakers-the-rat
  • askuric

@Kevin-Mattheus-Moerman
Copy link
Member

@Ajstros thanks for this submission to JOSS, I am an AEiC and am checking if this submission is in scope, and if so will help search for a handling editor. I have browsed through your paper and the repository readme. Would you be able to amend your statement of need section such that it also clearly sketches out the research application of this software? You can also cite typical works in this domain, and cite works that already use the software if any.
You can call @editorialbot generate pdf here to update the draft paper.

@Kevin-Mattheus-Moerman Kevin-Mattheus-Moerman added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 26, 2022
@Kevin-Mattheus-Moerman
Copy link
Member

@Ajstros it looks like most editors in this domain are currently handling other submission. I have therefore waitlisted this submission for the moment. We will assign an editor when one becomes available.

@Kevin-Mattheus-Moerman
Copy link
Member

@jarvist would this work be too far off topic for you to handle as editor?

@jarvist
Copy link

jarvist commented Jul 26, 2022

A bit too far away I'm afraid; sounds like more of a job for an electrical engineer, or at least an expt physicist who does a lot of hardware interaction.

@lucask07
Copy link

We should also add untzag to the list of potential reviewers. He has done extensive instrumentation work.

@Ajstros
Copy link

Ajstros commented Aug 1, 2022

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@Ajstros
Copy link

Ajstros commented Aug 1, 2022

@Kevin-Mattheus-Moerman Thank you for your help on this submission and for your feedback on the paper. We have updated the statement of need section of the paper to add the information you mentioned.

@danielskatz
Copy link

👋 @adi3 - would you be able to edit this submission?

@danielskatz
Copy link

@editorialbot invite @adi3 as editor

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@danielskatz
Copy link

👋 @adi3 - this is the other paper you were invited to edit. If you can take it too, please do. If not, please let me know.

@editorialbot editorialbot added the Track: 3 (PE) Physics and Engineering label Aug 12, 2022
@Ajstros
Copy link

Ajstros commented Sep 2, 2022

@danielskatz Is there anything we can do while we wait for an editor to become available?

@danielskatz
Copy link

no, sorry.

@danielskatz
Copy link

@Ajstros - given the wait, I'll go ahead and edit this submission.

@danielskatz
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @danielskatz is now the editor

@danielskatz danielskatz removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 11, 2022
@danielskatz
Copy link

👋 @untzag - Would you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @ixjlyons - Would you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @sptennak - Would you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @chekoduadarsh - Would you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @sneakers-the-rat - Would you be willing to review this JOSS submission?

@danielskatz
Copy link

👋 @askuric - Would you be willing to review this JOSS submission?

@untzag
Copy link

untzag commented Sep 14, 2022

@danielskatz you bet, please mark me as a reviewer

@danielskatz
Copy link

Thanks @untzag - I'll add you, and once we get a second reviewer as well, we'll start the review

@danielskatz
Copy link

@editorialbot add @untzag as reviewer

@editorialbot
Copy link
Collaborator Author

@untzag added to the reviewers list!

@askuric
Copy link

askuric commented Sep 14, 2022

Hi everyone,
I'd be happy to review this paper/repo but due to some work constraints I would not be able to start before the 25th of September.
If that is fine with your schedule don't hesitate to let me know.

@danielskatz
Copy link

@askuric - that's fine. I'll add you, and start the review now, but will add a note there that you will be delayed in starting until 25 Sept. Thanks!!

@danielskatz
Copy link

@editorialbot add @askuric as reviewer

@editorialbot
Copy link
Collaborator Author

@askuric added to the reviewers list!

@danielskatz
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4762.

@askuric
Copy link

askuric commented Sep 14, 2022

OK perfect thanks, I'm looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants