-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: sknet: A Python framework for Machine Learning in Complex Networks #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @dvysardana, @drj11 it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
PDF failed to compile for issue #3864 with the following error:
|
@osorensen the PDF isn't compiling. Should it be? Is that where i would expect to find the full author list? |
Thanks for letting me know @drj11. The paper is in a separate branch, so we need some special syntax. |
@whedon generate pdf from branch docs/joss_paper |
|
Good work whedon! |
@osorensen, @whedon, I have completed my review. |
Thanks @dvysardana. Do I understand correctly that you think a statement of need is missing but otherwise everything is fine? |
Hello @osorensen
Yes, I have completed my review. The statement of need needs to be updated
to clearly mention the target audience. Further, the paper lacks a
description and comparison of other similar packages that already exist in
the community.
Can you please confirm that all the review requirements are complete now?
Thanks
Divya Sardana
…On Sun, Oct 31, 2021 at 12:01 AM Øystein Sørensen ***@***.***> wrote:
Thanks @dvysardana <https://github.com/dvysardana>. Do I understand
correctly that you think a statement of need is missing but otherwise
everything is fine?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3864 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6FQXZNUKIWGDXEBZKIQXLUJTSTLANCNFSM5G4K4XNQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Thanks a lot for your review @dvysardana . I can confirm that you have done what is requested for now, but once the authors report in this thread that they have added a statement if need and a target audience, please come back and compete the review checklist. I will tag you in this thread to make sure you get notified. |
@whedon generate pdf from branch docs/joss_paper |
|
Hello @dvysardana I've added more information about the target audience on the README and on the sphinx documentation. Do those changes meet the criteria for your revision? If not, do you have any suggestions on how to improve it to make it acceptable? Thank you for your review! |
Hello @TNanukem
Thanks for adding the additional information. These changes look good to
me. I have no other suggestions for improvement.
Best Regards
Divya Sardana
…On Tue, Nov 2, 2021 at 4:50 AM Tiago Toledo Junior ***@***.***> wrote:
Hello @dvysardana <https://github.com/dvysardana>
I've added more information about the target audience on the README and on
the sphinx documentation.
Also, I added more information about other packages on the paper.
Do those changes meet the criteria for your revision? If not, do you have
any suggestions on how to improve it to make it acceptable?
Thank you for your review!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3864 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6FQX4DTPGPHTF3NHD7WV3UJ7GATANCNFSM5G4K4XNQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Thank you @dvysardana. If anything else comes up I'm available for the changes proposed by you or @drj11 :) |
@dvysardana, please also remember to check the two reminaing boxes in your review checklist at the top of this issue. |
@osorensen Checked all the boxes in my review.
…On Thu, Nov 4, 2021 at 6:25 AM Øystein Sørensen ***@***.***> wrote:
@dvysardana <https://github.com/dvysardana>, please also remember to
check the two reminaing boxes in your review checklist at the top of this
issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3864 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE6FQX2LSEM4HYBHFYEPWB3UKKCUDANCNFSM5G4K4XNQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
👋 @drj11, please update us on how your review is going (this is an automated reminder). |
Oh good reminder @whedon I'll have a look this afternoon. |
@drj11, how is it going with your review? If there are issues which you think the authors should address, please mention them in this thread or by opening an issue in the source repository. |
|
@whedon generate pdf from branch docs/joss_paper |
|
@whedon set 10.5281/zenodo.5783027 as archive |
OK. 10.5281/zenodo.5783027 is the archive. |
@whedon set v0.0.1 as version |
OK. v0.0.1 is the version. |
@whedon recommend-accept |
|
PDF failed to compile for issue #3864 with the following error:
|
@whedon recommend-accept from branch docs/joss_paper |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2825 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2825, then you can now move forward with accepting the submission by compiling again with the flag
|
|
@whedon accept deposit=true from branch docs/joss_paper |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @TNanukem on your article's publication in JOSS! Many thanks to @dvysardana, @drj11, and @imw for reviewing this, and @osorensen for editing. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @TNanukem (Tiago Toledo Junior)
Repository: https://github.com/TNanukem/scikit-net/
Version: v0.0.1
Editor: @osorensen
Reviewers: @dvysardana, @drj11, @imw
Archive: 10.5281/zenodo.5783027
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dvysardana & @drj11, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @dvysardana
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @drj11
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @imw
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: