-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: PIVC: A C/C++ Program for Particle Image Velocimetry Vector Computation #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @timdewhirst, @clarka34, @quynhneo it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
Reproducing @timdewhirst 's comments from the pre-review issue (#3603):
|
@timdewhirst, @clarka34, @quynhneo this is where the actual review takes place. Thank you all for you help! |
@quynhneo to answer your query over at #3603, have a look at our review guidelines. Let me know if you have questions. |
I have added some more issues:
At this stage, my main concerns are the lack of real-word examples for users that are not very familiar with PIV. Additionally, the documentation could be extended and improved to make it easier for future collaboration/use of the software. It would be difficult for a person who is not familiar with PIV to understand the grid spacing options and what to do with the result files. |
@fibreglass2 as you may have seen there are a number of issues open that were raised by the reviewers. ☝️. Can you start to address these? Let me know if you have any questions. |
Sorry, my phone has had a mind of its own this morning. It seems like I have unassigned @timdewhirst and closed this. I reopened but could not figure out how to reassign. @Kevin-Mattheus-Moerman can you do this? |
@openjournals/dev can you check if I need to fix anything? ☝️ |
@clarka34 no worries we'll sort it out |
@Kevin-Mattheus-Moerman thank you! again, I am sorry about this... |
Thanks to the reviewers for the detailed feedback. I will be working to investigate and address issues raised. |
👋 @quynhneo, please update us on how your review is going (this is an automated reminder). |
👋 @timdewhirst, please update us on how your review is going (this is an automated reminder). |
Simply updated a citation in the paper. Thanks to the reviewers for their extensive and detailed feedback. |
@Kevin-Mattheus-Moerman Is this review completed? |
@fibreglass2 yes it is. Apologies for the delay! I will now process this for acceptance as soon as possible. There may be come minor edits required from my end of the paper and it should move relatively quickly now. |
@fibreglass2 I have read the paper and it looks good to me. A minor note, which you may or may not choose to work on, is that mostly we use At this point can you work on the following:
|
@editorialbot generate pdf |
DOI: 10.5281/zenodo.7556040
Author name and title are correct on Zenodo.
Newest version is v1.2-b The paper has been updated with corrected usage of "open source" and "closed source". |
@editorialbot set 10.5281/zenodo.7556040 as archive |
Done! Archive is now 10.5281/zenodo.7556040 |
@editorialbot set v1.2-b as version |
Done! version is now v1.2-b |
@editorialbot recommend accept |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3894, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on this publication @fibreglass2 !!! Our apologies for the longer than usual review process. I'd like to thank the reviewers @clarka34, @quynhneo, and also @timdewhirst for their help here!!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @fibreglass2 (Kadeem)
Repository: https://gitlab.com/fibreglass/pivc
Branch with paper.md (empty if default branch):
Version: v1.2-b
Editor: @Kevin-Mattheus-Moerman
Reviewers: @clarka34, @quynhneo
Archive: 10.5281/zenodo.7556040
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@timdewhirst & @clarka34 & @quynhneo, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @timdewhirst
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @clarka34
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @quynhneo
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: