Skip to content

[PRE REVIEW]: Nextclade: clade assignment, mutation calling and quality control for viral genomes #3691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whedon opened this issue Sep 3, 2021 · 47 comments

Comments

@whedon
Copy link

whedon commented Sep 3, 2021

Submitting author: @rneher (Richard Neher)
Repository: https://github.com/nextstrain/nextclade
Version: v1.3.0
Editor: @kellyrowland
Reviewers: @kevinlibuit, @DavidNickle
Managing EiC: Kyle Niemeyer

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b0e8e7f231ddfc61616de6b56f32b79f"><img src="https://joss.theoj.org/papers/b0e8e7f231ddfc61616de6b56f32b79f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b0e8e7f231ddfc61616de6b56f32b79f/status.svg)](https://joss.theoj.org/papers/b0e8e7f231ddfc61616de6b56f32b79f)

Author instructions

Thanks for submitting your paper to JOSS @rneher. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @will-rowe.

@rneher if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Sep 3, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 3, 2021

Wordcount for paper.md is 1366

@whedon
Copy link
Author

whedon commented Sep 3, 2021

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/0022-2836(81)90087-5 is OK
- 10.21105/joss.02906 is OK
- 10.1093/bioinformatics/bty407 is OK
- 10.1038/s41588-021-00862-7 is OK
- 10.1093/bioinformatics/bty191 is OK
- 10.1093/molbev/mst010 is OK
- 10.1038/s41564-021-00932-w is OK

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Sep 3, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Sep 3, 2021

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=6.56 s (312.7 files/s, 84154.0 lines/s)
---------------------------------------------------------------------------------------
Language                             files          blank        comment           code
---------------------------------------------------------------------------------------
JSON                                    40              0              0         145110
C++                                    671          23576          18754         122987
C/C++ Header                           501          26164          30133         110318
TypeScript                             341           3078            513          16037
Markdown                               143           4662              0          13575
Python                                  33           1984           3786           7857
CMake                                  120           1064           1230           5034
SVG                                     13              3              3           2076
Bourne Shell                            31            471            329           2004
YAML                                    40            255            134           1823
C                                        4            160            100           1300
Windows Module Definition               16            166            109           1114
make                                     9            193            143            800
Sass                                    13            165             19            757
JavaScript                              22            104             77            694
diff                                    17            121            437            398
XML                                      7              7             10            387
Dockerfile                               4             50             11            195
Bourne Again Shell                       1             20              8            165
Objective-C                              3             61             41            150
SWIG                                     1             21              3            142
Windows Resource File                    3             68             89            139
reStructuredText                         5            133            140            124
TeX                                      1             11              0            121
DOS Batch                                4             26             46             83
CSS                                      3             14              3             60
Bazel                                    2              5              0             44
PowerShell                               1             12              0             23
Meson                                    1              4              0             19
HTML                                     2              2              0             18
---------------------------------------------------------------------------------------
SUM:                                  2052          62600          56118         433554
---------------------------------------------------------------------------------------


Statistical information for the repository 'c0994c5a88584900827e007c' was
gathered on 2021/09/03.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Cornelius Roemer                 6           108              3            0.03
Richard Neher                   32           800            266            0.25
eharkins                         1             1              2            0.00
ivan-aksamentov                399        388631          41665           99.73

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Richard Neher                69            8.6          9.8               11.59
eharkins                      1          100.0          0.4                0.00
ivan-aksamentov          348419           89.7          3.5               17.08

@kyleniemeyer
Copy link

Hi @rneher, thanks for your interest in JOSS! Unfortunately, due to low editor availability in this area, I need to put your submission on our waitlist. Once an editor is able to handle this one, we'll get it assigned and moving forward.

@kyleniemeyer kyleniemeyer added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 3, 2021
@rneher
Copy link

rneher commented Sep 4, 2021

Thanks, @kyleniemeyer. I can suggest a few reviewers if this helps:

pvanheus
kevinlibuit
EduanWilkinson

let me know if there is anything else I can do to help.

@arfon
Copy link
Member

arfon commented Sep 9, 2021

@whedon invite @kellyrowland as editor

👋 @kellyrowland – would you be willing to take this submission on for us?

@whedon
Copy link
Author

whedon commented Sep 9, 2021

@kellyrowland has been invited to edit this submission.

@kellyrowland
Copy link

Yep, I can take this on.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @kellyrowland as editor

@whedon
Copy link
Author

whedon commented Sep 12, 2021

OK, the editor is @kellyrowland

@kellyrowland
Copy link

Thanks for the reviewer suggestions, @rneher !

Hello @pvanheus @kevinlibuit @EduanWilkinson 👋 - would you be interested in and available to review this paper for JOSS? We require a minimum of two reviewers per paper.

@kevinlibuit
Copy link

kevinlibuit commented Sep 16, 2021 via email

@kellyrowland
Copy link

Great! Thanks very much.

@kellyrowland
Copy link

@whedon add @kevinlibuit as reviewer

@whedon
Copy link
Author

whedon commented Sep 16, 2021

OK, @kevinlibuit is now a reviewer

@kellyrowland
Copy link

Hi @dcnickle @Maghnuso - would either of you be willing and available to review this submission to JOSS? I see that you were the reviewers on the paper for the Augur software package, which is used and referenced here.

@DavidNickle
Copy link

Hi Kelly,

Yes - I can review this.

David

@kellyrowland
Copy link

Great, thanks so much!

@kellyrowland
Copy link

@whedon add @dcnickle as reviewer

@whedon
Copy link
Author

whedon commented Sep 28, 2021

OK, @dcnickle is now a reviewer

@kellyrowland
Copy link

@whedon remove @dcnickle as reviewer

@whedon
Copy link
Author

whedon commented Sep 28, 2021

OK, @dcnickle is no longer a reviewer

@kellyrowland
Copy link

@whedon add @DavidNickle as reviewer

@whedon
Copy link
Author

whedon commented Sep 28, 2021

OK, @DavidNickle is now a reviewer

@kellyrowland
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 28, 2021

OK, I've started the review over in #3773.

@whedon whedon closed this as completed Sep 28, 2021
@Maghnuso
Copy link

Maghnuso commented Sep 28, 2021 via email

@danielskatz danielskatz removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Sep 28, 2021
@kellyrowland
Copy link

Hi @Maghnuso - thanks for your reply! We are all set with two reviewers here, so please do take the time off with your growing family (congrats!).

@EduanWilkinson
Copy link

@kellyrowland I would be happy to help with the review process.

Please advise with regards to how the GitHub review process works.

Regards,

@DavidNickle
Copy link

DavidNickle commented Sep 29, 2021 via email

@kellyrowland
Copy link

Hi David,

I can see your post over in the review issue, thanks - I'll go ahead and mark the checkboxes off over in that issue.

@kellyrowland
Copy link

Hi @EduanWilkinson we can add you as a third reviewer over in the review issue, sure.

The workflow would go as follows:

In the review issue at #3773 , I would @ whedon, the JOSS bot, and have it add you as a reviewer on the paper. This will send you an invite to the repository, which you'll need to accept to proceed with the review process.

Once you've been added as a reviewer and accepted the repo invite, you'll be assigned to the Github issue, where you'll have a set of 20 checkboxes to work through. You can take a look at the checkboxes in the issue linked previously; each reviewer is asked to work through this same set of checkboxes to ensure software functionality and documentation and review the associated paper.

Any questions or feedback for the authors can be raised on the software repo or in the review issue; reviewers and authors are encouraged to iterate as needed to arrive at a software and paper state appropriate for publication in JOSS. Once all reviewers have completed their reviews, I'll have the authors release a tagged version of the software to go with the paper and then ping the JOSS editors-in-chief to finish out the publication.

Please let me know if you have any questions about the above and if you are interested in and able to carry out the review - we can add you as a third reviewer on the submission.

@EduanWilkinson
Copy link

@whedon I accept to review the paper. Could you add me as a reviewer please?

Eduan

@whedon
Copy link
Author

whedon commented Sep 30, 2021

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests