-
-
Notifications
You must be signed in to change notification settings - Fork 41
[REVIEW]: PXO (Poly-XTAL Operations): Free MATLAB codebase to generate and analyse complex 2D grain structures #3190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @yangbai90, @ksyang2013, @littlelazy6 it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Failed to discover a |
|
|
@yangbai90, @ksyang2013, @littlelazy6 this is where the review takes place. Could you provide an indication as to the time you need to provide your initial review? FYI we can be flexible and it is okay if you need to take quite a bit of time. Thanks again for your help!!!! |
I will return the comments within two weeks. Thanks! |
👋 @yangbai90, please update us on how your review is going (this is an automated reminder). |
👋 @ksyang2013, please update us on how your review is going (this is an automated reminder). |
👋 @littlelazy6, please update us on how your review is going (this is an automated reminder). |
@SunilAnandatheertha |
Hello there,
Is the review process for this code still active?
I encountered following message "Sorry, we couldn't find that repository invitation. It is possible that the invitation was revoked or that you are not logged into the invited account.”
Thanks,
…--------------------------------------
Kesong YANG, Ph.D.
Associate Professor,
Department of NanoEngineering,
Program of Materials Science and Engineering,
Center for Memory and Recording Research (CMRR),
University of California San Diego
9500 Gilman Drive, Mail Code 0448
La Jolla, CA 92093-0448, USA
Office: SME 244H
Tel: (858) 534-2514
E-mail: ***@***.***
http://materials.ucsd.edu <http://materials.ucsd.edu/>
On May 2, 2021, at 6:10 AM, whedon ***@***.***> wrote:
👋 @ksyang2013 <https://urldefense.com/v3/__https://github.com/ksyang2013__;!!Mih3wA!XNLE3fVSIlS4xdgkhLSnAJxwfuduLw0XD1FD_QlsKkFjRFuUqPdKoMY0VPLq92s$>, please update us on how your review is going (this is an automated reminder).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/openjournals/joss-reviews/issues/3190*issuecomment-830807445__;Iw!!Mih3wA!XNLE3fVSIlS4xdgkhLSnAJxwfuduLw0XD1FD_QlsKkFjRFuUqPdKoMY07pFbaJk$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEHTG3FARUY2VUKZK3WBJH3TLVFNFANCNFSM43EGUGCA__;!!Mih3wA!XNLE3fVSIlS4xdgkhLSnAJxwfuduLw0XD1FD_QlsKkFjRFuUqPdKoMY07h-RRkQ$>.
|
@yangbai90 Thank you for the comment. Will include the performance related limitations in the code in the wiki page and will update here. |
@ksyang2013 Thank you for the update. I think @Kevin-Mattheus-Moerman would be the best person to help you in this issue. |
@whedon commands |
Here are some things you can ask me to do:
|
@whedon check references |
|
@whedon check repository |
@whedon generate pdf |
@whedon set 10.5281/zenodo.5142160 as archive |
OK. 10.5281/zenodo.5142160 is the archive. |
@Kevin-Mattheus-Moerman Thank you. I am not able to tick the checkboxes. |
@SunilAnandatheertha that is okay, I'll check them when ready. Note they remain unchecked now since those steps appear not to have been changed in the latest paper. I repeat them again below:
|
@Kevin-Mattheus-Moerman Thank you for this. I have updated it. @whedon generate pdf |
@whedon generate pdf |
@whedon recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2487 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2487, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on your accepted paper @SunilAnandatheertha (sunil anandatheertha) 🎉 Thank you @yangbai90, @ksyang2013, @littlelazy6 for reviewing this work! We really appreciate your help!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@Kevin-Mattheus-Moerman and the entire JOSS team: JOSS is a very good initiative. Thank you for this platform. Thank you also for considering the work in your journal. I am happy to see the acceptance. @ksyang2013 @yangbai90 @littlelazy6 Thank you so much for your review comments, they have been really helpful. Thank you all. |
Uh oh!
There was an error while loading. Please reload this page.
Submitting author: @SunilAnandatheertha (sunil anandatheertha)
Repository: https://github.com/SunilAnandatheertha/PXO
Version: V10.1.1
Editor: @Kevin-Mattheus-Moerman
Reviewer: @yangbai90, @ksyang2013, @littlelazy6
Archive: 10.5281/zenodo.5142160
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@yangbai90 & @ksyang2013 & @littlelazy6, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @yangbai90
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @ksyang2013
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @littlelazy6
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: