Skip to content

[PRE REVIEW]: Using drones to quantify the length of marine animals #2056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whedon opened this issue Feb 1, 2020 · 30 comments
Closed

[PRE REVIEW]: Using drones to quantify the length of marine animals #2056

whedon opened this issue Feb 1, 2020 · 30 comments

Comments

@whedon
Copy link

whedon commented Feb 1, 2020

Submitting author: @egemose (Henrik Dyrberg Egemose)
Repository: https://github.com/egemose/DroneVideoMeasure
Version: v1.0.0
Editor: @kthyng
Reviewers: @abhishekbajpayee, @jizecn

Author instructions

Thanks for submitting your paper to JOSS @egemose. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @kthyng.

@egemose if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Feb 1, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 1, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.49 s (115.4 files/s, 76884.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
JavaScript                       5           4476          10317          19136
Python                          15            212             65           1506
HTML                            28             66             20           1388
CSS                              2             60             31            356
Bourne Shell                     1             15              0            133
Markdown                         2             34              0            112
YAML                             2              1              0             24
TeX                              1              1              0             13
Dockerfile                       1              5              0             11
-------------------------------------------------------------------------------
SUM:                            57           4870          10433          22679
-------------------------------------------------------------------------------


Statistical information for the repository '2056' was gathered on 2020/02/01.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Henrik Dyrberg Egemo            35        112063          76351          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Henrik Dyrberg Egemo      35712           31.9          0.4               29.41

@whedon
Copy link
Author

whedon commented Feb 1, 2020

Reference check summary:

OK DOIs

- None

MISSING DOIs

- None

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Feb 1, 2020

@Kevin-Mattheus-Moerman
Copy link
Member

@egemose thanks for your submission. I recommend adding the software name in the paper title e.g.
DroneVideoMeasure: Using drones to quantify the length of marine animals

@Kevin-Mattheus-Moerman
Copy link
Member

@kthyng the authors suggested you as editor. Would you be able to edit this submission? You can likely also invite the authors/reviewers from this submission: #1825 to review this work.
If you cannot take this I can take it myself.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @kthyng as editor

@whedon
Copy link
Author

whedon commented Feb 3, 2020

@kthyng has been invited to edit this submission.

@kthyng
Copy link

kthyng commented Feb 3, 2020

Yes I can edit this

@kthyng
Copy link

kthyng commented Feb 3, 2020

@whedon assign @kthyng as editor

@whedon
Copy link
Author

whedon commented Feb 3, 2020

OK, the editor is @kthyng

@kthyng
Copy link

kthyng commented Feb 3, 2020

Hi @egemose! I have a few questions to get started. First, is there any documentation? I didn't see any on a quick scan through your repository.

@egemose
Copy link

egemose commented Feb 5, 2020

Hi @kthyng This is a new submission of #1654 where most of the software have been rewritten to work in docker and a browser, to ease the installation and use.

@egemose egemose mentioned this issue Feb 5, 2020
36 tasks
@egemose
Copy link

egemose commented Feb 5, 2020

@kthyng I can see that I forgot to redo the manual of the old repository with the documentation. I will quickly add it.

@egemose
Copy link

egemose commented Feb 6, 2020

@kthyng There is now documentation in the "manual" directory.

@egemose
Copy link

egemose commented Feb 6, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 6, 2020

PDF failed to compile for issue #2056 with the following error:

Error reading bibliography ./paper.bib (line 40, column 1):
unexpected "t"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@kthyng
Copy link

kthyng commented Feb 6, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Feb 6, 2020

@kthyng
Copy link

kthyng commented Feb 6, 2020

@egemose Ok I understand now.

I also now see that there are two Henriks working on this software! That was confusing at first.

Ok I will try to recruit our original reviewers.

@kthyng
Copy link

kthyng commented Feb 6, 2020

Hi @abhishekbajpayee and @jizecn! You were reviewers on a previous submission to JOSS which was paused for some code improvements. It has been resubmitted in this PRE-REVIEW issue. Are you able and willing to review it at this point?

@abhishekbajpayee
Copy link

Yes I can review.

@jizecn
Copy link

jizecn commented Feb 13, 2020

Hi @abhishekbajpayee and @jizecn! You were reviewers on a previous submission to JOSS which was paused for some code improvements. It has been resubmitted in this PRE-REVIEW issue. Are you able and willing to review it at this point?

Yes, I will review too.

@kthyng
Copy link

kthyng commented Feb 13, 2020

Excellent! Thanks to both of you once again.

@kthyng
Copy link

kthyng commented Feb 13, 2020

@whedon assign @abhishekbajpayee as reviewer

@whedon
Copy link
Author

whedon commented Feb 13, 2020

OK, @abhishekbajpayee is now a reviewer

@kthyng
Copy link

kthyng commented Feb 13, 2020

@whedon add @jizecn as reviewer

@whedon
Copy link
Author

whedon commented Feb 13, 2020

OK, @jizecn is now a reviewer

@kthyng
Copy link

kthyng commented Feb 13, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Feb 13, 2020

OK, I've started the review over in #2097.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants