Skip to content

[PRE REVIEW]: ASCENDS: Advanced data SCiENce toolkit for Non-Data Scientists #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whedon opened this issue Jul 25, 2019 · 25 comments
Closed

Comments

@whedon
Copy link

whedon commented Jul 25, 2019

Submitting author: @ornlpmcp (Sangkeun Lee)
Repository: https://github.com/ornlpmcp/ASCENDS
Version: v0.4.0
Editor: @terrytangyuan
Reviewers: @zhampel, @jrbourbeau

Author instructions

Thanks for submitting your paper to JOSS @ornlpmcp. Currently, there isn't an JOSS editor assigned to your paper.

@ornlpmcp if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 25, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jul 25, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 25, 2019

PDF failed to compile for issue #1594 with the following error:

ORCID looks to be the wrong length
/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:123:in block in check_orcids': Problem with ORCID (orcid.org/0000-0002-1317-5112) for Sangkeun Lee (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:121:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:121:in check_orcids' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:81:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@kyleniemeyer
Copy link

Hi @terrytangyuan, can you edit this submission?

@kyleniemeyer
Copy link

Hi @ornlpmcp, thanks for your submission to JOSS. Please merge the PR I just submitted, which fixes an issue with an ORCID preventing compilation of your paper: ornlpmcp/ASCENDS#1

@terrytangyuan
Copy link
Member

@whedon assign @terrytangyuan as editor

@whedon
Copy link
Author

whedon commented Jul 25, 2019

OK, the editor is @terrytangyuan

@terrytangyuan
Copy link
Member

👋 Hi @ornlpmcp if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

@terrytangyuan
Copy link
Member

Hi @mkhorton @nagoue @lebebr01 @scivision @suman-d @janfreyberg, if you would like to review this submission, please let us know here!

@janfreyberg
Copy link

I unfortunately have a very busy August so won't be available for reviews until September

@ornlpmcp
Copy link

@desilinguist @krother @jkahn @vchuravy would you please review this submission? @terrytangyuan I just started following this thread. Sorry for the late reply.

@desilinguist
Copy link

desilinguist commented Aug 12, 2019 via email

@ornlpmcp
Copy link

@jrbourbeau @fernandoandreotti @kdpeterson51 @zhampel would you please take a look and see if you can review this? Thank you so much @terrytangyuan please help to assign a reviewer for this paper. Thanks a lot!

@zhampel
Copy link

zhampel commented Aug 14, 2019

@ornlpmcp I can review this submission.

@ornlpmcp
Copy link

@zhampel Thank you!

@ornlpmcp
Copy link

Dear @terrytangyuan
@zhampel agreed to review this submission. Please proceed. Thanks.

@terrytangyuan
Copy link
Member

We need at least two reviewers for a submission.

@jrbourbeau
Copy link

@ornlpmcp I'm happy to review as well

@terrytangyuan
Copy link
Member

@whedon assign @zhampel as reviewer

@whedon whedon assigned terrytangyuan and zhampel and unassigned terrytangyuan Aug 17, 2019
@whedon
Copy link
Author

whedon commented Aug 17, 2019

OK, the reviewer is @zhampel

@terrytangyuan
Copy link
Member

@whedon add @jrbourbeau as reviewer

@whedon
Copy link
Author

whedon commented Aug 17, 2019

OK, @jrbourbeau is now a reviewer

@terrytangyuan
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 17, 2019

OK, I've started the review over in #1656. Feel free to close this issue now!

@terrytangyuan
Copy link
Member

@jrbourbeau @zhampel Thank you! Look forward to your review in #1656!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants