Skip to content

[PRE REVIEW]: SCONE: Open Source Software for Predictive Simulation of Biological Motion #1394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whedon opened this issue Apr 19, 2019 · 33 comments

Comments

@whedon
Copy link

whedon commented Apr 19, 2019

Submitting author: @tgeijten (Thomas Geijtenbeek)
Repository: https://github.com/opensim-org/SCONE
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewers: @modenaxe, @demotu

Author instructions

Thanks for submitting your paper to JOSS @tgeijten. Currently, there isn't an JOSS editor assigned to your paper.

@tgeijten if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Apr 19, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Apr 19, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Apr 19, 2019

PDF failed to compile for issue #1394 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1394 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:57:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@arfon
Copy link
Member

arfon commented Apr 19, 2019

👋 @Kevin-Mattheus-Moerman - the submitting author suggested you as the handling editor.

@arfon
Copy link
Member

arfon commented Apr 19, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 19, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Apr 19, 2019

@tgeijten
Copy link

Thanks! The bullets points (*) don't show up correctly. Are they supported?

@arfon
Copy link
Member

arfon commented Apr 19, 2019

The Markdown parser is a little fussy and needs there to be whitespace before the first bullet. This PR should fix the rendering: opensim-org/SCONE#47

@tgeijten
Copy link

Great, thanks! I merged the PR.

@arfon
Copy link
Member

arfon commented Apr 20, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 20, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Apr 20, 2019

@danielskatz
Copy link

👋 @Kevin-Mattheus-Moerman - ping... the submitting author suggested you as the handling editor.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @Kevin-Mattheus-Moerman as editor

@whedon
Copy link
Author

whedon commented Apr 22, 2019

OK, the editor is @Kevin-Mattheus-Moerman

@Kevin-Mattheus-Moerman
Copy link
Member

@modenaxe @chrisdembia @moorepants @trallard @demotu @nicoguaro would you be interested in reviewing this work for JOSS?

@nicoguaro
Copy link

@Kevin-Mattheus-Moerman, currently I am reviewing another work for JOSS. So, I will decline this one.

@demotu
Copy link

demotu commented Apr 22, 2019 via email

@moorepants
Copy link
Member

I am not currently available to review.

@trallard
Copy link
Member

I am sorry @Kevin-Mattheus-Moerman but I have some other reviews down the line that I really need to get going so I am going to pass on this one

@modenaxe
Copy link

I can review it. Also, I have tried the alpha version of SCONE few months ago - just disclosing this in case it constitutes a problem -.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon assign @modenaxe as reviewer

@whedon
Copy link
Author

whedon commented Apr 27, 2019

OK, the reviewer is @modenaxe

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon add @demotu as reviewer

@whedon
Copy link
Author

whedon commented Apr 27, 2019

OK, @demotu is now a reviewer

@Kevin-Mattheus-Moerman
Copy link
Member

Kevin-Mattheus-Moerman commented Apr 27, 2019

@tgeijten let me know if you'd like to recommend any reviewers

@tgeijten
Copy link

Friedl de Groote, Seungmoon Song. Perhaps @chrisdembia knows anyone else?

@tgeijten
Copy link

@Kevin-Mattheus-Moerman how many reviewers are needed?

@kyleniemeyer
Copy link

@tgeijten Generally JOSS likes to have at least two reviewers, though we can also have one if the editor serves as a second reviewer.

@Kevin-Mattheus-Moerman
Copy link
Member

@tgeijten I usually aim for at least 2, which we already have, but I wanted to give you the chance to add some recommended reviewers. To avoid further delay we'll start the review process now.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented May 1, 2019

OK, I've started the review over in #1421. Feel free to close this issue now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests