Skip to content

[PRE REVIEW]: WGS2NCBI - Toolkit for preparing genomes for submission to NCBI #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
whedon opened this issue Mar 29, 2019 · 23 comments
Closed

Comments

@whedon
Copy link

whedon commented Mar 29, 2019

Submitting author: @rvosa (Rutger Vos)
Repository: https://github.com/naturalis/wgs2ncbi
Version: v1.0.0
Editor: @lpantano
Reviewers: @druvus

Author instructions

Thanks for submitting your paper to JOSS @rvosa. Currently, there isn't an JOSS editor assigned to your paper.

@rvosa if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 29, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Mar 29, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 29, 2019

PDF failed to compile for issue #1353 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5469df74be0c/lib/whedon.rb:83:in check_fields': Paper YAML header is missing expected fields: affiliations (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5469df74be0c/lib/whedon.rb:69:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5469df74be0c/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5469df74be0c/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5469df74be0c/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5469df74be0c/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@danielskatz
Copy link

@rvosa, please check your paper source, using https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography as an example/template. When you've made changes, enter @whedon generate pdf as a new comment here, and iterate until you are happy with the paper. Then we'll start the pre-review process by assigning an editor.

@danielskatz
Copy link

👋 bioinformatics editing team (@pjotrp @mgymrek @brainstorm @lpantano) - can one of you take on this submission as editor?

@rvosa
Copy link

rvosa commented Mar 29, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Mar 29, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 29, 2019

👉 Check article proof 📄 👈

@pjotrp
Copy link

pjotrp commented Mar 31, 2019

wave bioinformatics editing team (@pjotrp @mgymrek @brainstorm @lpantano) - can one of you take on this submission as editor?

We'll take it on. Thanks @rvosa for submitting this interesting tool!

@danielskatz
Copy link

danielskatz commented Apr 3, 2019

👋 @pjotrp @mgymrek @brainstorm @lpantano - it would be great if whichever of you is willing to edit this would assign it yourself as editor :)

@lpantano
Copy link

lpantano commented Apr 3, 2019

@whedon assign @lpantano as editor

@lpantano
Copy link

lpantano commented Apr 3, 2019

@danielskatz @arfon I think whedon doesn't like me anymore ..... it doesn't assign me as editor, maybe I lost permissions :/

@kyleniemeyer
Copy link

@whedon assign @lpantano as editor

@whedon
Copy link
Author

whedon commented Apr 3, 2019

OK, the editor is @lpantano

@kyleniemeyer
Copy link

@lpantano weird! I had also been noticing some delays with whedon, maybe that was the issue.

@arfon
Copy link
Member

arfon commented Apr 3, 2019

@whedon list editors

@whedon
Copy link
Author

whedon commented Apr 3, 2019

Current editors:

@Kevin-Mattheus-Moerman
@VivianePons
@alexhanna
@arfon
@arokem
@brainstorm
@cMadan
@danielskatz
@eramirem
@gkthiruvathukal
@jasonclark
@jedbrown
@karthik
@katyhuff
@kthyng
@kyleniemeyer
@labarba
@leouieda
@lheagy
@lpantano
@mgymrek
@pjotrp
@poulson
@trallard
@usethedata
@xuanxu
@yochannah

@ooo
Copy link

ooo bot commented Apr 3, 2019

👋 Hey @whedon...

Letting you know, @trallard is currently OOO until Sunday, April 7th 2019. ❤️

@arfon
Copy link
Member

arfon commented Apr 3, 2019

@danielskatz @arfon I think whedon doesn't like me anymore ..... it doesn't assign me as editor, maybe I lost permissions :/

Hrm, not sure what's up here.

@lpantano
Copy link

lpantano commented Apr 4, 2019

@whedon assign @druvus as reviewer

@whedon
Copy link
Author

whedon commented Apr 4, 2019

OK, the reviewer is @druvus

@lpantano
Copy link

lpantano commented Apr 4, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Apr 4, 2019

OK, I've started the review over in #1364. Feel free to close this issue now!

@lpantano lpantano closed this as completed Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants